/hg/release/icedtea-web-1.2: Removed uses of synchronization on ...

Deepak Bhole dbhole at redhat.com
Tue May 22 10:48:00 PDT 2012


* Adam Domurad <adomurad at redhat.com> [2012-05-22 13:42]:
> On Tue, 2012-05-22 at 12:41 -0400, Omair Majid wrote:
> > Hi Adam,
> > 
> > Just a note that we normally require a separate review for backporting a
> > patch to a release branch. In this case, it looks fine to backport. But
> > generally we leave things in HEAD for a little while to soak first.
> > 
> > On 05/22/2012 12:11 PM, adomurad at icedtea.classpath.org wrote:
> > > changeset 886414736595 in /hg/release/icedtea-web-1.2
> > > details: http://icedtea.classpath.org/hg/release/icedtea-web-1.2?cmd=changeset;node=886414736595
> > > author: Adam Domurad <adomurad at redhat.com>
> > > date: Tue May 22 12:11:10 2012 -0400
> > > 
> > > 	Removed uses of synchronization on Boolean object.
> > > 
> > > 
> > > diffstat:
> > > 
> > >  plugin/icedteanp/java/sun/applet/PluginStreamHandler.java |  12 ++++--------
> > >  1 files changed, 4 insertions(+), 8 deletions(-)
> > > 
> > 
> > Also, you are supposed to update the ChangeLog too ;) No need for a
> > separate review for just that though. Just commit the changes to the
> > ChangeLog.
> > 
> > Cheers,
> > Omair
> 
> 
> Sorry. I interpreted this comment from Deepak:
> > Looks good to me! OK for 1.1/1.2/HEAD from me.
> As permission to go ahead and backport it. And yes, an oversight on my
> part. I'll update the ChangeLog.
> 

Hi Adam,

I actually did mean that it can go into all branches. I didn't ask for
separate branch patches due to the minor scale of the change (and I had
already looked at 1.0/1.1 code before approving).

Cheers,
Deepak



More information about the distro-pkg-dev mailing list