[2.2 BRANCH] Allow providers to pass TestAES even if they don't provide wrap mode

Andrew Hughes ahughes at redhat.com
Wed May 23 10:29:34 PDT 2012


----- Original Message -----
> Hi Andrew,
> 
> it looks ok for me.
> 
> (and it seems you already fixed it in IcedTea6)
> 
> There's only one (probably minor issue) - do you use tabs for
> indentation
> or spaces as in original test?
> 

Whatever the editor used.   It's easily corrected by the normaliser anyway.

Patch committed.

> Cheers,
> Pavel
> 
> > 
> > 
> > -------- Original Message --------
> > Subject: [2.2 BRANCH] Allow providers to pass TestAES even if they
> > don't
> > provide wrap mode
> > Date: Wed, 16 May 2012 11:43:57 +0100
> > From: Dr Andrew John Hughes <ahughes at redhat.com>
> > To: distro-pkg-dev at openjdk.java.net
> > 
> > If a cryptography provider doesn't support a particular mode or
> > algorithm,
> > it throws exception.  At present, the tests added in u4 skip
> > testing that
> > function of such providers, with the exception of wrapping in
> > TestAES,
> > which instead throws the exception up to the user and causes the
> > test to
> > fail.  This treats a request for wrap mode like the others, and
> > skips the
> > test if it's not available.
> > 
> > Ok for 2.2 branch?
> > 
> 
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07




More information about the distro-pkg-dev mailing list