[icedtea-web] RFC: Fix fpr PR863: Error passing strings to applet methods in Chromium

[Danesh Dadachanji]

Hi Deepak,

On 08/03/12 05:17 PM, Deepak Bhole wrote:
> Hi,
>
> Attached patch fixes PR863. Currently, the plug-in relies on the
> "UTF8Characters" property of NPString to get the char* array. However
> browsers like chromium don't always trim the array correctly, resulting
> in reads beyond the length.
>
> This patch checks for length in all places where UTF8Characters is used
> and reads only upto the length.
>
> ChangeLog:
> 2012-03-08  Deepak Bhole<dbhole at redhat.com>
>
>      * plugin/icedteanp/IcedTeaJavaRequestProcessor.cc
>      (createJavaObjectFromVariant): Account for length of the characters.
>      * plugin/icedteanp/IcedTeaNPPlugin.cc (plugin_get_documentbase): Same.
>      * plugin/icedteanp/IcedTeaPluginRequestProcessor.cc (_eval): Print the
>      string's c_str rather than utf8characters/

Extra "/" there

>      * plugin/icedteanp/IcedTeaPluginUtils.cc (printNPVariant): Account for
>      length of the characters.
>      (NPVariantToString): Same.
>      (isObjectJSArray): Same.
>
>
> OK for 1.1, 1.2 and HEAD?
>

Looks like this fell through the cracks.

You've taken care of PR518[1] as well. Can you update the ChangeLog to include this and NEWS entries for the various branches? would 
you mind also making sure none of the recent changesets have thrown any of this off? Sorry for that, this should have gone in ages ago!

The patch itself looks good to me though, thanks for taking care of the bugs!

Cheers,
Danesh