[rfc][icedtea-web] Simple for-each loop style patch

Pavel Tisnovsky ptisnovs at redhat.com
Fri May 25 08:25:14 PDT 2012


Adam Domurad wrote:
> Hey all. I find the for-each syntax that Java 1.5 to be pretty clear in
> intent when it comes to data structure iteration. I went through the
> code and changed some occurrences of explicit index/iterator loops to
> for-each.

Hi Adam,

your changes are correct, ok for HEAD.

Cheers,
Pavel

> 
> OK for HEAD ? (Ran with run-netx-dist-tests with 21/104 failures)
> 
> Changelog:
> 2012-05-25  Adam Domurad <adomurad at redhat.com>
> 
> 	Changed for-loops over iterators and indices to for-each loops if they
> 	were sufficient and clearer.	
> 	*netx/net/sourceforge/jnlp/JNLPFile.java: Changed for-loops that could
> 	be expressed more clearly as for-each loops.
> 	*netx/net/sourceforge/jnlp/PluginBridge.java: Same
> 	*netx/net/sourceforge/jnlp/ResourcesDesc.java: Same
> 	*netx/net/sourceforge/jnlp/cache/CacheUtil.java: Same
> 	*netx/net/sourceforge/jnlp/cache/DefaultDownloadIndicator.java: Same
> 	*netx/net/sourceforge/jnlp/cache/Resource.java: Same
> 	*netx/net/sourceforge/jnlp/cache/ResourceTracker.java: Same
> 	*netx/net/sourceforge/jnlp/runtime/AppletEnvironment.java: Same
> 	*netx/net/sourceforge/jnlp/runtime/ApplicationInstance.java: Same
> 	*plugin/icedteanp/java/netscape/javascript/JSObject.java: Same
> 	*plugin/icedteanp/java/sun/applet/JavaConsole.java: Same
> 	*plugin/icedteanp/java/sun/applet/PluginAppletViewer.java: Same
> 
> 
> 
>  
> 




More information about the distro-pkg-dev mailing list