[rfc][icedtea-web] Ignore invalid .jar files specified for plugin

Adam Domurad adomurad at redhat.com
Fri May 25 12:54:46 PDT 2012


So, I realize after some thought that this probably shouldn't be in
JarCertVerifier. However this is where the .jar files are uncompressed
and thus the location where the ZipException could be caught and dealt
with. Suggestions ? To be sure the .jar files are valid they must be
unzipped first, via new JarFile(...).

On Fri, 2012-05-25 at 15:17 -0400, Adam Domurad wrote:
> So, first patch that isn't something trivial, I'll definitely need
> people to weigh in on this one. 
> 
> The proprietary plug-in seems to just skip over any malformed .jar files
> and carry on loading. This patch emulates that behaviour. 
> This alleviates some of the symptoms of
> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1011 
> However, the plugin should still parse folders differently and look for
> resources in folders like the proprietary plug-in does.
> 
> ChangeLog:
> 2012-05-25  Adam Domurad <adomurad at redhat.com>
> 
> 	Ignore invalid jar files, like the oracle plugin does.
> 	* netx/net/sourceforge/jnlp/tools/JarCertVerifier.java: Added extra 
> 	possible verification result, INVALID_JAR. This value occurs if the
> 	.jar file could not be properly loaded. The .jar file is then ignored.





More information about the distro-pkg-dev mailing list