[rfc] [icedtea-web] reproducers with custom makefile

Jiri Vanek jvanek at redhat.com
Sat May 26 12:39:32 PDT 2012


Hi!

We have been speaking with Danes that although current reproducers compilation and signing mechanism is very powerful, sometimes it really can not cover some extraordinary case.
For this purpose we ahve come with idea to have special class of reproducers (next to signed and simple) - in this patch called custom - which will have its own makefile and will take care for itself.
This is implementation of this idea. What do you think? both for idea and implementation :)

One think I do not like on this change -  exporting of variables. In plain Makefile I would use "export". It looks like in Automake this is not possible. (I suspect comaptibility issues gnu x normal make), so I have exported most crucial variables manually.
When I saw result Makefile I was wandering that the makefile is still working.... Well loks like was working correctly. Any hint welcomed!

J.

	* Makefile.am:  Most crucial variables exported to be used by custom Makefiles
	(junit-jnlp-dist-custom.txt): new target scanning for directories in jnlp_tests/custom
	and saving them as list for future purposes.
	(stamps/process-custom-reproducers.stamp): new target for iterating by junit-jnlp-dist-custom.txt
	through  jnlp_tests/custom/* and launching make prepare-reproducer in each
	(clean-custom-reproducers): same as above but launching make clean-reproducer
	(run-netx-dist-tests) now depends on stamps/process-custom-reproducers.stamp
	(clean-netx-dist-tests): now depends on clean-custom-reproducers
	* tests/jnlp_tests/README: described this mechanism a bit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: customMakefiles.diff
Type: text/x-patch
Size: 11512 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120526/f6560f71/customMakefiles.diff 


More information about the distro-pkg-dev mailing list