[RFC][icedtea-web] Signed JNLP file: added regression tests

[Omair Majid]

On 05/28/2012 01:03 PM, Saad Mohammad wrote:
> Hello,
> 
> The attached patches contains the suggested changes and some additional
> tests requested from the previous email. The three patches tests the
> launch of applications with:
> 
>     1) A signed JNLP application/template file
>     2) An unsigned JNLP application/template file
>     3) A signed jnlp application/template file with case
>        insensitive filenames
> 

I dont quite follow the patch. Much of this already exists as unit
tests. Why duplicate it?

IMHO, it makes much more sense to verify all the corner cases of signed
jnlp files (missing elements, extra elements, elements not exactly
matching) in unit tests, and have reproducer tests to ensure that the
matching rules that you have already extensively tested using unit tests
are being applied.

Also, because so many tests are now duplicates, it means that changing
one detail in the implementation will require you to modify multiple tests.

Cheers,
Omair