[PATCH] Introduced --with-gtk option for configure.ac

[Jiri Vanek]

On 05/29/2012 08:27 AM, Peter Hatina wrote:
> On 05/28/2012 10:14 PM, Andrew Hughes wrote:
>>
...
>>>>
>>>> Minor issues:
>>>>
>>>> 1.  Why not just --with-gtk=2?  Or better, --with-gtk-version=2?
>>>> 2.0 is confusing because most people will have something like 2.24.
>>>
>>> Habit from other project, such as WebKit. The 2.0 or 3.0 is also used
>>> for pkg-config gtk+-2.0 [ options ].
>>>
>>
>> But we can add the '.0' ourselves.  Just because some other project does
>> it doesn't make it right.
>>
>
> Ok.

You can still use condition to allow both your habits and suggested simplified input.
I would be happy with this as I'm also used to use  --with-gtk=X.0 much rather then 
--with-gtk-version=X.

Actually I'm much for --with-gtk=X.0 as it is spread over gtk project I have worked with. But I see 
Andrew's point too.

SO some middle way according to your judgement will be the best :)

>
>>>> 2.  Shouldn't "default" be allowed through the case block in
>>>> IT_CHECK_PLUGIN_DEPENDENCIES?
>>>
>>> I do not get this.
>>>
>>
>> Why
>>
>>>>> +       2.0|3.0) ;;
>>
>> and not
>>
>>>>> +       2.0|3.0|default) ;;
>>
>> ?
>
> Ah, I see your point, ok.
>
J.