[rfc][icedtea-web] handling of multiple testing certificates in bulk

[Pavel Tisnovsky]

Hi Jiri,

your change looks good in overall, I just have some notes listed bellow this paragraph:

+EXPORTED_TEST_CERT_SUFIX=crt
should be named EXPORTED_TEST_CERT_SUFFIX ;-)

+	  find .  -maxdepth 1 -mindepth 1 | sed "s/.\/*//" > $(abs_top_builddir)/junit-jnlp-dist-$$which.txt ; \
Is not it easier to use 'ls' in this situation given you use -maxdepth=1 and -mindepth=1?

+Directory "signed" is listed in Makefile.am. You can specifi as much to-be-signed
s/specifi/specify

Cheers,
Pavel

Jiri Vanek wrote:
> Hi!
> 
> There come an need to test applications consisted from several jars,
> each signed by different certificate. Also there is need to work with
> diferent certificates in custom-makefiles reproducers.
> This changeset is introducing unlimited number of certificates for
> future purposes.
> Even if this multiple certs will never be used, I'm for put it in,
> because it is gathering copy pasted code to variables.
> 
> J.
> 
> 
>     * Makefile.am: EXPORTED_TEST_CERT by EXPORTED_TEST_CERT_PREFIX and
> EXPORTED_TEST_CERT_SUFIX for further composition
>     SIGNED_REPRODUCERS new variable for  iterating through signed
> reproducers
>     SIMPLE_REPRODUCERS new variable for  iterating through simple
> reproducers
>     ALL_REPRODUCER new variable for  iterating through all reproducers
>     (junit-jnlp-dist-signed.txt) replaced by
> (stamps/junit-jnlp-dist-signed.stamp) which generates
> junit-jnlp-dist-signedX.txt for each directory with signed reproducers
>     (stamps/netx-dist-tests-prepare-reproducers.stamp)
> (stamps/change-dots-to-paths.stamp)
> (stamps/netx-dist-tests-compile-testcases.stamp)
> (run-netx-dist-codecoverage): extracted variables
>     (clean-netx-dist-tests):  iterates through all the list and removes
> them
>     (stamps/netx-dist-tests-sign-some-reproducers.stamp): now iterate
> through SIGNED_REPRODUCERS and creates special certificate for each
> member. Each jar from this directory is then signed by corresponding
> certificate
>     (netx-dist-tests-remove-cert-from-public): iterates through all
> certificates
>     (stamps/netx-dist-tests-import-cert-to-public): exports each
> certificate created during tests preparations
>     ($(EXPORTED_TEST_CERT)) replaced by stamps/exported-test-certs.stamp
> which create for each of SIGNED_REPRODUCERS individual certificate
>     (tests/jnlp_tests/README): mentioned possibility of multiple
> certificates
>     
>