[rfc][icedtea-web] Fix for PR1011, folders in archive tag

[Adam Domurad]

Slightly revised patch attached.

On Wed, 2012-05-30 at 13:30 +0200, Pavel Tisnovsky wrote:
> Hi Adam,
> 
> you changes look ok, TY.
> 
> a quick review:
> 
> minor-refactoring patch: changes to for-each loops look ok
> 
> folders-in-archive-tag.patch:
> almost everything look ok, I just think it would be better
> to use Lists instead of arrays for following object attributes:
> 
> +    private String[] codeBaseFolders = new String[0];
>      String[] cacheJars = new String[0];
>      String[] cacheExJars = new String[0];
> 
> The code will be cleaner and it will contain fewer conversions List<->Array (AFAIK).
> 
> +            if (archiveEntry.endsWith("/")){
> I'm really not sure what separator is used in if it is not better to use File.pathSeparator instead of "/"
> - do we have any JAR created on Windows? ;-)
> 
> 
> Pavel
> 
> 
> 
> Adam Domurad wrote:
> > This resolves http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1011
> > Entries in the archive tag can potentially be folders. This removes the
> > assumption that everything in the archive tag is a jar, and adds folders
> > to the code-base.
> > This brings the icedtea-web plugin closer to how the proprietary plugin
> > functions. 
> > 
> > Also attached is a small bit of refactoring to PluginBridge, for
> > approval.
> > 
> > (Note that the proprietary plugin also ignores invalid jar files in
> > archive tags - I have another patch awaiting review "Re:
> > [rfc][icedtea-web] Ignore invalid .jar files in applets" that provides
> > this behaviour.)
> > 
> > Changelog:
> > 2012-05-29  Adam Domurad  <adomurad at redhat.com>
> > 
> > 	Allow for folders in archive tag.	
> > 	* netx/net/sourceforge/jnlp/PluginBridge.java:
> > 	(PluginBridge) Changes jar -> archive, parse contents with
> > 	addArchiveEntries.
> > 	(addArchiveEntries) New method. Adds entries ending with / to the list
> > 	of folders.
> > 	(getCodeBaseFolders) Returns the folders collected by addArchiveEntries
> > 	* netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java:
> > 	(initializeResources) If ran as plugin, add archive tag folders to the
> > 	code base loader.
> > 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: folders-in-archive-tag2.patch
Type: text/x-patch
Size: 4253 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120530/951f43bb/folders-in-archive-tag2.patch