[rfc][icedtea-web] Tiny patch to make last param in applet tag take effect, was first

[Adam Domurad]

Gah. Always forget to group-reply.

Here are two reproducers, one for checking that the final param is taken
in a .jnlp file (current behaviour), and one for checking that the final
param is taken in a .html file (post-patch behaviour).

ChangeLog:
2012-05-31  Adam Domurad  <adomurad at redhat.com>
	
	Reproducers to ensure that equivalent parameters take the value of the
	second parameter tag to occur.
	*
tests/jnlp_tests/simple/AppletTakesLastParam/resources/appletTakesLastParam.html: 
	New, tests parameter duplication in applet-tags.
	*
tests/jnlp_tests/simple/AppletTakesLastParam/resources/appletTakesLastParam.jnlp: 
	New, tests parameter duplication in jnlp files.
	*
tests/jnlp_tests/simple/AppletTakesLastParam/srcs/AppletTakesLastParam.java:
	New, reads a duplicated parameter, 'param'.
	*
tests/jnlp_tests/simple/AppletTakesLastParam/testcases/AppletTakesLastParamTests.java:
	New, drives test for duplicated param in .jnlp and .html files.

Cheers, 
Adam

On Thu, 2012-05-31 at 08:47 +0200, Jiri Vanek wrote:
> On 05/30/2012 11:14 PM, Omair Majid wrote:
> > On 05/30/2012 05:04 PM, Omair Majid wrote:
> >> On 05/30/2012 04:57 PM, Adam Domurad wrote:
> >>> Tiny patch to make handling of applet tags more like Oracle's plugin.
> >>> This makes our plugin take into account the last<param ...>  tag with
> >>> the same 'name'. It was taking into account the first such tag.
> >>>
> >>> 2012-05-30  Adam Domurad<adomurad at redhat.com>
> >>> 	
> >>> 	* plugin/icedteanp/java/sun/applet/PluginAppletViewer.java:
> >>> 	(parse) Small change to have last<param name=... value=...>  tag to
> >>> 	take effect.
> >>
> >
> > Btw, I would strongly encourage you to write a reproducer (or unit) test
> > for this.
> >
> > Cheers,
> > Omair
> 
> Definitely. Please provide reproducer before push of this changeset.
> 
> Thanx in advance, J.




-------------- next part --------------
A non-text attachment was scrubbed...
Name: reproducers-param-dupe.patch
Type: text/x-patch
Size: 10928 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120531/a7e367d9/reproducers-param-dupe.patch