[rfc][icedtea-web] Fix two memory leaks

Saad Mohammad smohammad at redhat.com
Mon Nov 19 13:35:55 PST 2012


On 11/19/2012 12:34 PM, Adam Domurad wrote:
> get_cookie_info and get_proxy_info take a char** that holds a result from an
> NPN_GetValueForURLPtr browser callback.
> 
> This string is not freed, however the documentation [1] states the plugin is
> responsible for freeing the buffer.
> 
> 2012-11-19  Adam Domurad  <adomurad at redhat.com>
> 
>     * plugin/icedteanp/IcedTeaNPPlugin.cc
>     (consume_plugin_message): Free two buffers returned from NPN_GetValueForURL
> function.
> 
> 
> [1]  https://developer.mozilla.org/en-US/docs/NPN_GetValueForURL

Hi Adam,

Thanks for taking a sharper look on the C++ side. The patch looks good to me.

-- 
Cheers,
Saad Mohammad



More information about the distro-pkg-dev mailing list