[rfc] [icedtea-web] applets are more error reporting to user
Pavel Tisnovsky
ptisnovs at redhat.com
Mon Nov 26 04:35:09 PST 2012
Hi Jiri,
this change looks reasonable. I just feel you need to add volatile modifier to "boolean finished" variable.
Thanks,
Pavel
----- Jiri Vanek <jvanek at redhat.com> wrote:
> This small patch (yah, fix itself have just one line) is adding visual experience to user if his applet fatally fails.
>
> You can see nice example in one of our testcases - http://www.knuddels.de:8080/index.html?v=90aez&c=7
>
> I'm working on mechanism how to show much more errors by this way, but it will net native support on plugin side, so I'm waiting to Deepak with it.
>
> The included testcase I'm using for manual tracking of various exceptions. Imho I would like to push it and so do not need to keep ii in mind that it is somewhere on local drive.
>
> Thanx for any comments !
> //to be honest hoping for direct approve :)
>
> J.
>
>
> 2012-11-23 Jiri Vanek <jvanek at redhat.com>
>
> Better error reporting from applets
> * netx/net/sourceforge/jnlp/NetxPanel.java: (init) ErrorSplash is shown
> if fatal exception is cought
> * plugin/icedteanp/java/sun/applet/PluginAppletViewer.java: (replaceSpalsh)
> is rather removing all then just its previous version
> * tests/reproducers/simple/AppletTest/srcs/AppletErrorTest.java:
> * tests/reproducers/simple/AppletTest/resources/errorAppletAutoTests.html
> Testcase for manual testing of various exceptions from applet
More information about the distro-pkg-dev
mailing list