[icedtea-web][rfc] Refactor a JS<->Java function, add browser-table mocking to C++ unit tests

[Adam Domurad]

Hi all. This refactoring will help in the fix for the JSObject bug [1]

Firstly, to aid in testing this I added a simple mechanism for mocking 
browser callbacks:

Testing framework ChangeLog:
2012-11-XX  Adam Domurad  <adomurad at redhat.com>

     Added a simple mechanism for mocking functions in the browser function
     table. Can be exapanded as needed.
     * tests/cpp-unit-tests/main.cc: Call setup function, warn on browser
     function based memory leak.
     * tests/cpp-unit-tests/browser_mock.cc: New, implements simple
     error-checking mocks of browser callbacks.
     * tests/cpp-unit-tests/browser_mock.h: New, interface to mocking
     functions.

A further idea for testing these functions (which rely on 
JavaRequestProcessor) is to have a different version of this class when 
compiling for unit tests. This would effectively 'mock' the class 
without having to modify the extensibility of the actual class (eg can 
make everything virtual but thats intrusive).

The refactoring introduces two convenience methods, and breaks up 
IcedTeaPluginUtilities::javaResultToNPVariant into multiple, more 
manageable parts. This will make it easier to apply the fix (which 
requires a special case for sun.plugin.JSObject like the one done on 
java.lang.String). This refactoring is in jsfunc-refactor.patch, and 
(since the patch doesn't read well) copied into newjsfunc-snippet.cpp.

Refactoring ChangeLog:
2012-11-XX  Adam Domurad  <adomurad at redhat.com>

     Breaks up IcedTeaPluginUtilities::javaResultToNPVariant into multiple,
     more manageable parts.
     * plugin/icedteanp/IcedTeaPluginUtils.cc: Make three helper functions
     for the different cases. Two new helper functions for converting from
     std::string to NPString and NPVariant.
     * plugin/icedteanp/IcedTeaPluginUtils.h: Two new helper functions.
     * tests/cpp-unit-tests/IcedTeaPluginUtilsTest.cc: Tests for the new
     NPString and NPVariant from std::string functions.


[1] http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1198


Happy hacking,
-Adam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: browsermock.patch
Type: text/x-patch
Size: 6524 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20121129/4804001d/browsermock.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jsfunc-refactor.patch
Type: text/x-patch
Size: 11790 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20121129/4804001d/jsfunc-refactor.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: newjsfunc-snippet.cpp
Type: text/x-c++src
Size: 3681 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20121129/4804001d/newjsfunc-snippet.cpp