[RFC][icedtea-web]: Fix PR1166 - Embedded JNLP File is not supported in applet tag

Saad Mohammad smohammad at redhat.com
Wed Oct 3 11:10:03 PDT 2012


Hi Adam,

Thanks for looking over my patches. I updated the reproducers after your review.
Along with the attached reproducer, I also added unit test and updated the bug
fix patch so it is more compatible with tests.

Also, just a note, the reproducers do all pass for me through the test engine.
Let me know if you are having any trouble.

Thanks.

CHANGELOGS:
==============================================================================
BUG FIX:

2012-10-03  Saad Mohammad  <smohammad at redhat.com>

	Fix PR1166: Embedded JNLP File is not supported in applet tag.
	* configure.ac: Checks for sun.misc.BASE64Encoder and
	sun.misc.BASE64Decoder
	* netx/net/sourceforge/jnlp/JNLPFile.java (JNLPFile):
	New constructor which accepts inputstream of jnlp file and a
	specified codebase.
	* netx/net/sourceforge/jnlp/Parser.java (Parser): If parsing of
	codebase fails, it will overwrite the codebase with the one passed
	in through parameters.
	* netx/net/sourceforge/jnlp/PluginBridge.java:
	(PluginBridge) Supports embedded jnlp file.
	(decodeBase64String) Decodes Base64 strings to byte array.
==============================================================================
REPRODUCER:

2012-10-03  Saad Mohammad  <smohammad at redhat.com>

	Added reproducer for PR1166.
	* tests/reproducers/simple/EmbeddedJnlpInApplet/resources/EmbeddedJnlp.jnlp:
	Launching jnlp file that is used by jnlp_href in applet tag
	*
tests/reproducers/simple/EmbeddedJnlpInApplet/resources/EmbeddedJnlpInAppletNoCodebase.html:
	Applet with an embedded jnlp file with no codebase specified
	*
tests/reproducers/simple/EmbeddedJnlpInApplet/resources/EmbeddedJnlpInAppletWithDotCodebase.html:
	Applet with an embedded jnlp file with codebase set as a 'dot'
	* tests/reproducers/simple/EmbeddedJnlpInApplet/resources/JnlpInApplet.html:
	Applet with jnlp_href file.
	* tests/reproducers/simple/EmbeddedJnlpInApplet/srcs/EmbeddedJnlp.java:
	Simple class that outputs strings.
	*
tests/reproducers/simple/EmbeddedJnlpInApplet/testcases/EmbeddedJnlpInAppletTest.java:
	Testcase that tests embedded jnlps in html pages.

==============================================================================
UNIT TESTS:

2012-10-03  Saad Mohammad  <smohammad at redhat.com>

	* tests/netx/unit/net/sourceforge/jnlp/JNLPFileTest.java:
	Tests the JNLPFile constructor that accepts an InputStream and an alternative
codebase.
	* tests/netx/unit/net/sourceforge/jnlp/ParserTest.java:
	Tests if the constructor handles the alternative codebase parameter correctly.
	* tests/netx/unit/net/sourceforge/jnlp/PluginBridgeTest.java:
	Tests if BASE64 strings are decoded correctly and if PluginBridge is
constructed with an
	embedded jnlp.

==============================================================================


-- 
Cheers,
Saad Mohammad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: BUG_FIX0-3.patch
Type: text/x-patch
Size: 4585 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20121003/cec443b1/BUG_FIX0-3.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: BUG_FIX_Changelog-News0-3.patch
Type: text/x-patch
Size: 1255 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20121003/cec443b1/BUG_FIX_Changelog-News0-3.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: REPRODUCER0-3.patch.patch
Type: text/x-patch
Size: 23583 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20121003/cec443b1/REPRODUCER0-3.patch.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: REPRODUCER_Changelog0-3.patch
Type: text/x-patch
Size: 1103 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20121003/cec443b1/REPRODUCER_Changelog0-3.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: UNIT_TEST0-3.patch
Type: text/x-patch
Size: 15921 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20121003/cec443b1/UNIT_TEST0-3.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: UNIT_TEST-Changelog0-3.patch
Type: text/x-patch
Size: 702 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20121003/cec443b1/UNIT_TEST-Changelog0-3.patch 


More information about the distro-pkg-dev mailing list