[RFC][icedtea-web]: Fix PR1166 - Embedded JNLP File is not supported in applet tag

Omair Majid omajid at redhat.com
Tue Oct 9 12:13:55 PDT 2012


On 10/03/2012 02:10 PM, Saad Mohammad wrote:
> Hi Adam,
> 
> Thanks for looking over my patches. I updated the reproducers after your review.
> Along with the attached reproducer, I also added unit test and updated the bug
> fix patch so it is more compatible with tests.
> 
> Also, just a note, the reproducers do all pass for me through the test engine.
> Let me know if you are having any trouble.
> 

Sorry about jumping in the middle, but this looks less-than-desirable:

>  IT_CHECK_FOR_CLASS(SUN_NET_WWW_PROTOCOL_JAR_URLJARFILECALLBACK, [sun.net.www.protocol.jar.URLJarFileCallBack])
>  IT_CHECK_FOR_CLASS(SUN_AWT_X11_XEMBEDDEDFRAME, [sun.awt.X11.XEmbeddedFrame])
>  IT_CHECK_FOR_CLASS(SUN_MISC_REF, [sun.misc.Ref])
> +IT_CHECK_FOR_CLASS(SUN_MISC_BASE64ENCODER, [sun.misc.BASE64Encoder])
> +IT_CHECK_FOR_CLASS(SUN_MISC_BASE64DECODER, [sun.misc.BASE64Decoder])
>  IT_CHECK_FOR_CLASS(COM_SUN_JNDI_TOOLKIT_URL_URLUTIL, [com.sun.jndi.toolkit.url.UrlUtil])
>  IT_CHECK_FOR_CLASS(SUN_APPLET_APPLETIMAGEREF, [sun.applet.AppletImageRef])
>  IT_CHECK_FOR_APPLETVIEWERPANEL_HOLE

Please use net.sourceforge.jnlp.util.replacements.BASE64Encoder instead
of sun.misc.Base64Encoder.

Thanks,
Omair



More information about the distro-pkg-dev mailing list