[icedtea-web][rfc] Fix to AppletBaseURL reproducer

Adam Domurad adomurad at redhat.com
Tue Oct 16 13:24:18 PDT 2012


On 10/16/2012 03:56 PM, Omair Majid wrote:
> On 10/12/2012 01:31 PM, Adam Domurad wrote:
>> This fixes random failures caused by the 'xception' matcher, as well as
>> speeding up execution.
> I suspect it's a SecurityException thrown because applet's are not
> allowed to invoke System.exit(). Maybe you should wrap it up in a
> try-catch (-and-ignore) block. That would avoid changes to the xception
> matcher.
>
> Could you update the comment on the System.exit line to be more accurate
> too?
>
> The changes to sleep/timeout look fine.
>
> Cheers,
> Omair
>

I would argue that the 'xception' matcher is overly broad and a test 
weakness. Currently there is a NPE while looking up the security context 
- which I think is caused by this exit() call. However, there's a lot of 
things that can cause exceptions on shutdown, I think (Jiri may know 
better here.) This is why I'm in favour of changing 'xception' to the 
appropriate exception, or getting rid of it if its just a catch-all.

Updated patch attached, with 'xception' matcher still removed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: appletbaseurlfix2.patch
Type: text/x-patch
Size: 8982 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20121016/03099069/appletbaseurlfix2.patch 


More information about the distro-pkg-dev mailing list