[rfc][icedtea-web] JNLPClassLoader oldstyle forloops made to for-each loops, minor cleanup

[Jiri Vanek]

On 10/02/2012 09:05 PM, Adam Domurad wrote:
> On 07/09/2012 09:44 AM, Jiri Vanek wrote:
>> On 07/06/2012 09:28 PM, Adam Domurad wrote:
>>> You may notice I don't like looking at old style for loops ...
>>>
>>> 2012-07-06 Adam Domurad<adomurad at redhat.com>
>>>
>>> * netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java:
>>> Changed some old-style for-loops -> for-each loops. Small code cleanup
>>> and generic type Class references changed to Class<?>.
>>
>> Do you mind to add unittests to all methods you are touching? (any souch a touch is good reason to add some;) )
>> With unittests, I'm ok for head, 1.3, and 1.2.
>>
>>
>> J.
> Ping. Never did come up with any worthwhile unit tests, can you elaborate on what you had in mind?

This change must be tested. You can do some extendings of  tested classes you are touching, and at least execute the methods you have modified.
When you will try it for several outputs and investigate outputs by anyway. Even some dummy counter of iterations or type checking... Most important will be that the code will be executed. I can see that evaluate correctness of such a method will be nearly impossible.
J.
>
> Thanks,
> - Adam