[rfc][icedtea-web] a new reproducer LiveConnect "set" tests
Adam Domurad
adomurad at redhat.com
Wed Oct 24 10:15:25 PDT 2012
On 10/24/2012 10:39 AM, Jana Fabrikova wrote:
> Hello Adam, thanks again. The reproducer seems much simpler already:-)
>
> I incorporated the comments in new version of the patch (the attached
> file).
>
> - the initializations of variables really could be simplified, so i
> did it.
> - the AssertFalse(has there been an error or exception) was not
> included , since all the tests pass in this version, maybe if there is
> some typical error/exception in the future use, it would make sense,
>
> Jana
>
Thanks for sticking with it, looks good to me! OK to push to HEAD.
Thanks,
- Adam
More information about the distro-pkg-dev
mailing list