FYI [PATCH] add missing backslash

Andrew Hughes ahughes at redhat.com
Mon Sep 3 13:59:10 PDT 2012



----- Original Message -----
> There were some failures in the icedtea6 build caused by some patches
> not being applied. For some reason automake/make seems to not warn
> about this which makes it hard to spot. The fix is trivial:
> 
> # HG changeset patch
> # User Mark Wielaard <mark at klomp.org>
> # Date 1346695613 -7200
> # Node ID 7fe15479d7193af69af48e675b55f12bc01fc1a2
> # Parent  db084058f69b1b244f198e2ea90e52351abccd02
> Makefile.am (ICEDTEA_PATCHES): Add missing backslash.
> 
> There was backslash missing after
> 7034464-transparent_huge_pages.patch
> which caused all patches after that one to be note included in the
> list.
> 
> diff -r db084058f69b -r 7fe15479d719 ChangeLog
> --- a/ChangeLog Mon Sep 03 14:30:48 2012 +0100
> +++ b/ChangeLog Mon Sep 03 20:06:53 2012 +0200
> @@ -1,3 +1,8 @@
> +2012-09-03  Mark Wielaard  <mark at klomp.org>
> +
> +       * Makefile.am (ICEDTEA_PATCHES): Add missing backslash after
> +       patches/openjdk/7034464-transparent_huge_pages.patch.
> +
>  2012-09-03  Andrew John Hughes  <ahughes at redhat.com>
>  
>         * NEWS: Add 1.10.9 & 1.11.4.
> diff -r db084058f69b -r 7fe15479d719 Makefile.am
> --- a/Makefile.am       Mon Sep 03 14:30:48 2012 +0100
> +++ b/Makefile.am       Mon Sep 03 20:06:53 2012 +0200
> @@ -349,7 +349,7 @@
>         patches/openjdk/6986968-crash_on_xim_restart.patch \
>         patches/openjdk/7036754-stroker-nan.patch \
>         patches/openjdk/pgram-pipe-regression.patch \
> -       patches/openjdk/7034464-transparent_huge_pages.patch
> +       patches/openjdk/7034464-transparent_huge_pages.patch \
>         patches/openjdk/7037939-disable_adaptive_resizing_with_large_pages.patch
>         \
>         patches/openjdk/7043564-hugepage.patch \
>         patches/openjdk/mutter.patch \
> 
> 

Ah, good spot.  This is why I should always rebuild, no matter how trivial the change (just a rename here) :-(
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07




More information about the distro-pkg-dev mailing list