[fyi][icedtea-web] fixed reproducer engine for better reproducing of PR905

[Pavel Tisnovsky]

Hi Jiri,

in overall I think this fix is ok, but I have some objections (as usual :-):

1) should be cteateCodeBase according to Java code style:
+    private void createCodeBAse(String originalResourceName, String newResourceName, URL codebase) throws MalformedURLException, IOException {

2) s/to strict/too strict:
+//        to strict!

3) s/Ctreate/Create

4) there's wrong indentation on the third line  (Ctrl+Shift+F in Eclipse, gg=G in Vim :)

+    public URL getUrlUponThisInstance(String resource) throws MalformedURLException {
+        getInstance();
+       return getUrlUponInstance(server,resource);
+    }

5) missing spaces before and after =
+                        p=p.replaceAll("\\?.*", "");


If this minor issues were fixed, I'm ok with pushing to HEAD.

Thank you,
Pavel



----- Jiri Vanek <jvanek at redhat.com> wrote:
> I had an flaw in processing of "?" query in test-engine. Here I'm fixing it with enhanced pr905 
> testcase and other minor clean-ups in engine.
> 
> this should go to head and 1.3
> 
> 2012-09-03  Jiri Vanek  <jvanek at redhat.com>
> 
> 	Fixing several errors which were causing incorrect behaviour causing
> 	correct reproduction of PR905
> 	* tests/reproducers/simple/ParametrizedJarUrl/resources/ParametrizedJarUrlSigned.htm
> 	Using different jar for reproducing
> 	* tests/reproducers/simple/ParametrizedJarUrl/testcases/ParametrizedJarUrlTests.java
> 	Added tests for hardcoded codebase (same and different)
> 	enhanced original PR905 reproducers
> 	* tests/test-extensions/net/sourceforge/jnlp/LoggingBottleneck.java:
> 	added flush for logs
> 	* tests/test-extensions/net/sourceforge/jnlp/ServerAccess.java: cleaned
> 	and enhanced getUrl* methods.
> 	* tests/test-extensions/net/sourceforge/jnlp/ServerLauncher.java: delegated
> 	socket
> 	* tests/test-extensions/net/sourceforge/jnlp/TinyHttpdImpl.java: fixed
> 	processing of question mark.