[fyi][icedtea-web] strict test

[Jiri Vanek]

On 09/06/2012 03:35 PM, adomurad wrote:
> On Thu, 2012-09-06 at 15:26 +0200, Jiri Vanek wrote:
>> Just simple test about passing of -strict parameter.  I Have written it to my to do long ago, donot
>> remember even why... so finally done...
>>
>>
///
>
> Hey just skimming, comments inline.

Thanx for review!
>
>
...
>> +        }
>> +        String ss = "xception";
>> +        if (negate) {
> Surely one of these should be !negate ??

Surely not! Do I see something wrong? (possible)
What do you don't like?

>> +            Assert.assertTrue("testSimpletest1lunchOk stderr should
...
>> +    }
>> +
>> +    private void createStrictFile(String originalResourceName, String
>> newResourceName, URL codebase) throws MalformedURLException,
>> IOException {
>> +        String originalContent = ServerAccess.getContentOfStream(new
>> FileInputStream(new File(server.getDir(), originalResourceName)));
>> +        String nwContent1 = originalContent.replaceAll("href=
>> \"simpletest1.jnlp\"", "href=\"simpletest1_strict.jnlp\"");
> I'm not sure how I feel about this rewriting scheme. I suppose its less
> error prone here than putting it manually, and less work than a custom
> reproducer.

The reason for this is the codebase. I need full url here, that means knowledge of port. And port is known only in runtime :(
So i will need this substitution even where there will be some simple1_strict.jnlp.in, there will still be needed substitution.
>
> One thing I would suggest though is, you rely on 'originalResourceName'
> to be passed to you, but then the method assumes the href is
> "simpletest1.jnlp". Surely you want to use originalResourceName and

I have done this intentionally, but actually - why not.

Minor fixed patch atatched.

J.
> newResourceName variables here ?
>> +        String nwContent = nwContent1.replaceAll("codebase=\".\"",
>> "codebase=\"" + codebase + "\"");
>> +        ServerAccess.saveFile(nwContent, new File(server.getDir(),
>> newResourceName));
>> +    }
>> +}
>
> Will look into again once these are fixed.
> Thanks, Adam.
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: strictTest2.diff
Type: text/x-patch
Size: 4257 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120906/712a6543/strictTest2.diff