[RFC][icedtea-web]: Added signed jnlp tests for applications using multiple jars

[Adam Domurad]

On Wed, 2012-09-05 at 15:54 -0400, Saad Mohammad wrote:
> On 08/13/2012 04:05 PM, Adam Domurad wrote:
> > I'm afraid you'll have to elaborate on this because I'm not aware of
> > when jnlp files are classified as signed. 
> 
> Hi Adam,
> 
> Sorry for the late reply and all the confusion. I updated the patch with major
> changes that includes additional comments and better file names. I think this
> patch will be much easier to understand. Sorry again for the confusion.
Thanks! Yes, it is. Sorry it to me so long to understand. 

[.. snip ..]
> +    public static void main(String[] args) throws Exception {
> +        System.out.println("Starting application with signed
> application jnlp");
> +
> +        //No parameters
> +        Class noparam[] = {};
> +
> +        //Run SignedJnlpTemplate
> +        Class c1 = Class.forName("SignedJnlpTemplate");
> +        Method m1 = c1.getDeclaredMethod("run", noparam);
> +        m1.invoke((Object) c1.newInstance());
Why are you creating a new instance here, but not below (in
m2.invoke(c2)) ? Also, casting to (Object) should never be necessary. 
> +        //Run SimpleApplication
> +        Class c2 = Class.forName("SimpleApplication");
> +        Method m2 = c2.getDeclaredMethod("run", noparam);
> +        m2.invoke((Object) c2);
> +
> +        System.out.println("Ending application with signed
> application jnlp");
> +    }
> +}
> 
[.. snip ..]
> 
>     @Test
>     public void mainJarMatchingSignedJnlpTemplate() throws Exception {
>         ProcessResult pr = server.executeJavawsHeadless(l, "/MainJarWithMatchingSignedJnlpTemplate.jnlp");
>         String s = "Ending application with signed application_template jnlp";
>         Assert.assertTrue("Could not locate SignedJnlpTemplate class within MultiJar-SignedJnlpTemplate.jar", pr.stdout.contains(s));
>     }
While not strictly necessary, it would be nice to add a corresponding assertFalse for the case where it completes successfully. (same for failing test below) 
> 
>     @Test
>     public void mainJarMatchingSignedJnlpApplication() throws Exception {
>         ProcessResult pr = server.executeJavawsHeadless(l, "/MainJarWithMatchingSignedJnlpApplication.jnlp");
>         String s = "Ending application with signed application jnlp";
>         Assert.assertTrue("Could not locate SignedJnlpApplication class within MultiJar-SignedJnlpApplication.jar", pr.stdout.contains(s));
>     }
It would also be nice here to add a corresponding assertFalse for the case where it errors out.
> 
>     @Test
>     public void mainJarWithUnmatchingSignedJnlpApplication() throws Exception {
>         ProcessResult pr = server.executeJavawsHeadless(l, "/MainJarWithUnmatchingSignedJnlpApplication.jnlp");
>         Assert.assertTrue("Stdout should contains " + signedJnlpException + " but did not", pr.stderr.contains(signedJnlpException));
>     }
> 
>     @Test
>     public void mainJarWithUnmatchingSignedJnlpTemplate() throws Exception {
>         ProcessResult pr = server.executeJavawsHeadless(l, "/MainJarWithUnmatchingSignedJnlpTemplate.jnlp");
>         Assert.assertTrue("Stdout should contains " + signedJnlpException + " but did not", pr.stderr.contains(signedJnlpException));
>     }
> 
>     @Test
>     public void mainJarWithoutSignedJnlp() throws Exception {
>         ProcessResult pr = server.executeJavawsHeadless(l, "/MainJarWithoutSignedJnlp.jnlp");
>         String s = "Ending application without a Signed Jnlp";
>         Assert.assertTrue("Stdout should contains " + s + " but did not", pr.stdout.contains(s));
>     }

Good tests (once I finally understood them, sorry this was a lack of
knowledge on my part).

Once you add a few more checks (and remove casts/ .newInstance() call in
your main classes if you feel like it/is correct) you can push to HEAD.

Thanks
- Adam