[icedtea-web] Feedback requested - reworking JNLPClassLoader#foundMainJar

[Saad Mohammad]

On 08/28/2012 04:57 PM, Adam Domurad wrote:
> Motivation here is that I'm looking into adding additional code to make
> sure main class's can be found via INDEX.LIST for PR1112 [1]. I had
> noticed already that simply hard-wiring foundMainJar = true; caused the
> reproducer I created to pass. 
> 
> What duties does foundMainJar accomplish other than causing a
> LaunchException ? Are there any major flaws in this approach used in the
> patch (using findLoadedClassAll)?
> 
Hi Adam,

The initial purpose of foundMainJar is to keep track of whether the loader has
the main jar. If the main jar is found, it will check and validate a signed jnlp
file, but if it is not found then it will throw a launch exception since the jar
with the main class is required to continue launching the application.

There were few bug [PR1041, and PR1042] that were found later causing
applications not to load correctly because their main jar were in extension
jnlps (extension loaders). The bug fix introduced few new methods and used
foundMainJar to determine if the current loader or the extension loader(s) have
the main jar.

Anyways, going to your second question, I am not aware of any flaws with
findLoadedClassAll() and and after looking over your code it seems to be doing
the same thing with fewer lines of code!

I ran the reproducers that have major impact on foundMainJar and they all seem
to be passing, so I give it a thumbs up for HEAD! :)

Thanks for doing this!

> (This patch is a rough sketch, don't scrutinize it -too- much :)
> 
> Thanks,
> - Adam
> 
> [1] http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1112
> 


-- 
Cheers,
Saad Mohammad