[RFC][icedtea-web] Fixes for PluginAppletSecurityContext

[Adam Domurad]

On Tue, 2012-08-28 at 15:49 -0400, Adam Domurad wrote:
> On Sun, 2012-08-19 at 16:59 +0200, Thomas Meyer wrote:
> > Am Freitag, den 10.08.2012, 15:07 -0400 schrieb Adam Domurad:
> > 
> > Hi,
> > 
> > > > +    private static class Signature {
> > > Good change. Multiple classes per file at top level is a rather obscure
> > > java feature.
> > > > +        private final String signature;
> > > > +        private final List<Class<?>> typeList;
> > [...]
> > > I'm going to have to take your word that this class is identical to what
> > > it was before ? I skimmed it and it looked OK.
> > 
> > I did test the parsing of the JNI signatures which are prepopulated via
> > prePopulateLCClasses(). Sadly these signatures contains no arrays. So
> > somebody should test JNI signatures containing arrays...
> > 
> > > 
> > > > +    private static class BrowserReadPermission extends
> > > > BasicPermission {
> > > >          public BrowserReadPermission() {
> > > >              super("browserRead");
> > > >          }
> > > > diff -r caefdb0bc90a plugin/icedteanp/java/sun/applet/PluginMain.java
> > > > --- a/plugin/icedteanp/java/sun/applet/PluginMain.java  Thu Aug 09
> > > > 20:14:53 2012 +0200
> > > > +++ b/plugin/icedteanp/java/sun/applet/PluginMain.java  Thu Aug 09
> > > > 20:57:20 2012 +0200
> > > > @@ -106,9 +106,7 @@
> > > >              // must be called before JNLPRuntime.initialize()
> > > >              JNLPRuntime.setRedirectStreams(redirectStreams);
> > > >  
> > > > -            PluginAppletSecurityContext sc = new
> > > > PluginAppletSecurityContext(0);
> > > > -            sc.prePopulateLCClasses();
> > > > -
> > > > PluginAppletSecurityContext.setStreamhandler(streamHandler);
> > > > +            PluginAppletSecurityContext sc = new
> > > > PluginAppletSecurityContext(0, streamHandler);
> > > >              AppletSecurityContextManager.addContext(0, sc);
> > > >  
> > > >              PluginAppletViewer.setStreamhandler(streamHandler);
> > > > 
> > > 
> > > Overall looks good! Definitely worth having. I very much like changes
> > > like this. In addition to my nits, needs a ChangeLog before being
> > > push-ready, though.
> > 
> > Update patch attached.
> > 
> > with kind regards
> > thomas
> 
> Sorry for the delay, thanks for the update! OK for HEAD from me.
>  - Adam
> 
> 

Ping. I did not see this committed and don't want it to become lost, it
was a good changeset. I can commit it under your name if need be.

- Adam