[icedtea-web][rfc] Basic closing listeners implementation and example

[Jiri Vanek]

On 09/20/2012 04:21 PM, Adam Domurad wrote:
> On Thu, 2012-09-20 at 12:22 +0200, Jiri Vanek wrote:
>
....
>> +    public static enum AutoClose {
>> +
>> +        CLOSE_ON_EXCEPTION, CLOSE_ON_CORRECT_END, CLOSE_ON_BOTH
> Maybe I'm being pedantic but CLOSE_ON_BOTH to me isn't as meaningful in
> isolation as I'd like it to be.
> Seeing as it's going to be the most common option, I would prefer if it
> was something like AutoClose.CLOSE_ON_EXIT, CLOSE_ON_EXCEPTION_EXIT,
> CLOSE_ON_CORRECT_EXIT. It should be readable in isolation, methinks.

If you can survive original naming, I would like to stay with old names. They looks clearer to me.
However -  if you can not - you are native speaker and feel free to force me:)

>
>> +    }
>> +
...
>> +import net.sourceforge.jnlp.ClosingListener;
>> +
>> +public  class AutoAllClosingListener extends ClosingListener {
> Seems like these 3 classes (Auto*ClosingListener) could be turned into a
> single class that takes a String[] argument. I would prefer that, but if
> you have reasons against this its fine.
>> +

Sure! Thanx for catch, it is much better now with common forefather!

>> +
>> +}
>>
>>
> Good patch! It should allow for a speed up of much of the tests without
> a terrible amount of effort.
>
> Thanks,
> - Adam
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: closingListener_5_1.diff
Type: text/x-patch
Size: 23020 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120924/98238f30/closingListener_5_1.diff