[RFC][icedtea-web]: Set plugin JVM options in itw-settings

[Adam Domurad]

On 12/05/2012 01:26 PM, Saad Mohammad wrote:
> On 12/05/2012 09:26 AM, Adam Domurad wrote:
>> On 12/04/2012 04:25 PM, Saad Mohammad wrote:
>>> Hi Adam,
>>>
>>> Thanks for all the tips and tricks around C++. Updated patch is attached!
>>> I'm starting to enjoy C++ as things start working more correctly now. :)
>> Good to hear :)
>>
>>> [..snip..]
>>> +  }
>>> +
>>> +  tokenOutput = IcedTeaPluginUtilities::strSplit(output, " \n");
>>> +
>>> +  if (!tokenOutput->empty() && *tokenOutput->at(0) =="null")
>>> +  {
>>> +    delete tokenOutput->at(0);
>>> +    tokenOutput->erase(tokenOutput->begin());
>>> +  }
>> A comment here about why you're deleting this token would be nice.
>>
>> Otherwise, I have no further torture to inflict on you :) Looks good to me now.
>> If you have tested it to your satisfaction, OK for HEAD.
>>
>> Thanks,
>> -Adam
>>
>>
> Thanks again for all the feedback!
> Pushed: <http://icedtea.classpath.org/hg/icedtea-web/rev/141cb4463629>
>

I would like to propose the patch + some clean-up that was eventually 
done for back-port to 1.3.
The clean-up simply extracted common elements from an if block and the 
else block. It was done as a part of Jiri's code-coverage 
instrumentation patch.

Some basic testing verifies that the jvm arguments are applied (putting 
gibberish is easiest). I have also read over the resulting code, and it 
checks out to me.

Thanks,
-Adam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jvm-settings-1.3.patch
Type: text/x-patch
Size: 15252 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130403/7914c2d1/jvm-settings-1.3.patch