[rfc][icedtea-web] dialogue for set jre dir

[Jiri Vanek]

On 04/05/2013 05:38 PM, Adam Domurad wrote:
> [.. Everything snipped ..]
>
> Looks good overall.
>
> - Detecting Oracle JDK works. However I'm not sure this is a 'great' result if nothing works. Also
> note:
> http://i.imgur.com/OwmiVVq.png
>
> This should be more clear that the warning is because we are not selecting OpenJDK, and perhaps say
> why (ie, plugin won't work)
>
> More issues:
> Using javaws with Oracle JDK:
> Your custom JRE /usr/java/jdk1.7.0_13 read from deployment.properties under key deployment.jre.dir
> as /usr/java/jdk1.7.0_13 is not valid. Using default (/usr/lib/jvm/java-openjdk/jre/bin/java,
> /usr/lib/jvm/java-openjdk/jre/lib/rt.jar) in attempt to start. Please fix this.
>

Yaaaah, there was really a bug in detection code! See line 352 of new and 328 of old patches... It 
explains also the wrong fallback - it was fallbacking  only for rt.jar

(
@@ -325,7 +349,7 @@
  +            }
  +        }
  +        File rtFile = new File(cmd + File.separator + "lib" + File.separator + "rt.jar");
-+        if (javaFile.isFile()) {
++        if (rtFile.isFile()) {
  +            validationResult += "<span color=\"green\">" + Translator.R("CPJVMrtJar") + 
"</span><br />";
  +        } else {
)

> Note thate bin/javaws exists in this directory. Adding a / to the end of the dir didn't help. It did
> at least fall back to IcedTea correctly.
>
> Using plugin with Oracle JDK:
> "Your custom jre (/lib/rt.jar check) /usr/java/jdk1.7.0_13/ is not valid. Please fix
> deployment.jre.dir in your deployment.properties. In attempt to run using default one.
> Exception in thread "PluginMessageHandlerWorker1" java.lang.IllegalAccessError: class
> net.sourceforge.jnlp.NetxPanel cannot access its superclass sun.applet.AppletViewerPanel"
>

catch (Exception ex){
//O:)
}

>> +            p.waitFor();
>> +            processErrorStream = StreamUtils.readStreamAsString(p.getErrorStream());
>> +            processStdOutStream = StreamUtils.readStreamAsString(p.getInputStream());
>> +            r = p.exitValue();
>> +            //System.err.println(processErrorStream);
>> +            //System.out.println(processStdOutStream);
>
...
>> +CPJVMjava=Ok, the directory you chose contains bin/java.
>> +CPJVMnoRtJar=Error, the directory you chose does not contain lib/rt.jar
>> +CPJVMrtJar=Ok, the directory you chose contains lib/rt.jar.
>> +CPJVMPluginAllowTTValidation=Allow type-time validation
>> +CPJVMNotokMessage1=You have entered invalid JDK value <u>({0})</u> with following error message:
>> +CPJVMNotokMessage2=With invalid JDK IcedTea-Web will probably not able to start.<br>You will have
>> to modify or remove <u>{0}</u> property in your configuration file <u>{1}</u>. <br>You should try
>> to search for OpenJDK in your system or be sure you know what you are doing.
>> +

Message a bit improved:

CPJVMNotokMessage2=You can see this message because of<blockquote> * Some validation have not 
passed<br> * Non-OpenJDK is detected</blockquote>With invalid JDK IcedTea-Web will probably not able 
to start.<br>You will have to modify or remove <u>{0}</u> property in your configuration file 
<u>{1}</u>. <br>You should try to search for OpenJDK in your system or be sure you know what you are 
doing.


>>
...
>
> Nothing else stands out code-wise, thanks for sticking with it.
>
> As far as I know, the bugs I mentioned above are related to already-pushed patches, so they can (and
> should) be fixed separately.
>
> To summarize before pushing, I view these as a must:
> - Remove commented out println's
> - Clarify the 'error message' that isn't an error in the image I showed. Please explicitly mention
> that the warning concerns not choosing IcedTea.
>
> And of course, consider the nits.
>
> You may push without sending to list again, your call.

rather resend if you can recheck...I will pusl later evening today
Thanx for review
J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: setupaAbleJVM-itwsettings_4.diff
Type: text/x-patch
Size: 23520 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130408/21c22a09/setupaAbleJVM-itwsettings_4.diff