[rfc][icedtea-web] Minor NetxPanel clean-up

Adam Domurad adomurad at redhat.com
Tue Apr 16 13:46:12 PDT 2013


This causes exceptions to be printed to console more clearly in two ways:

     1. It does not swallow launch exceptions in NetxPanel#runLoader, 
and the launch exception is printed instead of a spurious NPE.
     2. It sets the applet status to an error status in the exception 
path, preventing from further applet loading code, which would thrown an 
exception.

There is also some minor cleanup of a dead code path and a (quite) 
obsolete comment.

2013-XX-XX  Adam Domurad  <adomurad at redhat.com>

         * netx/net/sourceforge/jnlp/NetxPanel.java
         (exitOnFailure): Remove always-false field.
         (NetxPanel): Remove overloaded constructor
         (runLoader): Do not swallow LaunchException's. Remove dead
         exitOnFailure code-path. Set applet status to APPLET_ERROR on
         exception.
         * plugin/icedteanp/java/sun/applet/PluginAppletPanelFactory.java
         (createPanel): Update call to NetxPanel constructor.


Happy hacking,
-Adam
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130416/6085189c/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: netx-panel-minor-cleanup.patch
Type: text/x-patch
Size: 4084 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130416/6085189c/netx-panel-minor-cleanup.patch 


More information about the distro-pkg-dev mailing list