[rfc][icedtea-web] PluginAppletViewer unit tests with test extensions for mocking plugin input&output pipes

Adam Domurad adomurad at redhat.com
Tue Apr 23 08:57:30 PDT 2013


On 04/22/2013 05:17 AM, Jiri Vanek wrote:
> On 04/19/2013 08:31 PM, Adam Domurad wrote:
>> Hopefully more tasteful this time around :-)
>
>
> Ok. Walk through and I think it can go in. Two nits:
>
> 1)Maybe some test to new test-extension classes  would be worthy:(

I wouldn't want to anger the gods of quality assurance, attached is my 
meagre offering:

2013-04-XX  Adam Domurad  <adomurad at redhat.com>

     * tests/netx/unit/net/sourceforge/jnlp/AsyncCallTest.java: Unit 
tests for
     AsyncCall test extension.


> 2) checking the stared     Test utilities    methods.. When seeing 
> them separated ... well can be as it is, but (although I previously 
> said it in reverse way) maybe they are rally woorthy to be in separate 
> file in test extensions. But as you are confirming my previous 
> suspicions then it is probably ok and do your best.
>
> J.
>

I believe if they are needed they can be separated afterwards.

OK to push everything + this new test ?

Happy hacking,
-Adam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: async-call-test.patch
Type: text/x-patch
Size: 2816 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130423/7f860855/async-call-test.patch 


More information about the distro-pkg-dev mailing list