Regression in itw from Tue Mar 26

[Jiri Vanek]

Ok. So just fixed header.

On 04/24/2013 03:39 PM, Adam Domurad wrote:
> On 04/24/2013 08:34 AM, Jiri Vanek wrote:
>>> If you keep NullJnlpFileException, at the very least please get rid of the NetBeans stub
>> sure. Removed
>>
>>> - I strongly dislike testNullFileSecurityDesc & testNullFileSecurityDescApplet &
>>> testNullFileSecurityDescApplication.
>>
>> I really do not want to remove them. They already found a problem. Can do it even later...
>
> No. They *were* the problem; very different. I still want them gone :-). But I won't insist.
>

I would like to keep them at least for statistic purposes. it i so nice to have failing test which 
suddenly disappeared.

Otherwise I agree with you taht they are.. well "testing java" :)))

>>> See a pattern ? I think it's less confusing for future eyes. It certainly lead me to believe that
>>> this was somehow a valid case (and even you forgot original reason for the tests :-).
>>>
>>> Sorry if I come across as demanding & Feel free to disagree of course :-)
>>
>> done ;) J
>
> Thanks for disagreeing :-)
>
>>
>>
>> J.
>
>
...
>> -/**
>> - *
>> - * @author jvanek
>> - */
>>  public class NullJnlpFileException extends NullPointerException {
>
> [nit] What value does extending from NPE provide ?
>

Like from runtime exception. Practicaly none, except both are pointing to "null" something

No need to refactor anyway imho ....

>>
>>      public NullJnlpFileException() {
>> diff -r b912e91204b1 netx/net/sourceforge/jnlp/SecurityDesc.java
>> --- a/netx/net/sourceforge/jnlp/SecurityDesc.java    Tue Apr 23 13:59:20 2013 -0400
>> +++ b/netx/net/sourceforge/jnlp/SecurityDesc.java    Wed Apr 24 14:20:04 2013 +0200
>> @@ -149,6 +149,9 @@
...
>> +exception statement from your version.
>> + */
>> +package net.sourceforge.jnlp;
>> +
>> +import net.sourceforge.jnlp.mock.DummyJNLPFile;
>> +import org.junit.Assert;
>> +import org.junit.Test;
>> +
>> +
>> +public class SecurityDescTest {
>> +
>> +    @Test
>> +    public void testNotNullJnlpFile(){
>> +        SecurityDesc securityDesc = new SecurityDesc(new DummyJNLPFile(),
>> SecurityDesc.SANDBOX_PERMISSIONS, "hey!");
>> +        Assert.assertNotNull("securityDesc should not be ",securityDesc);
>
> What is this, a Java sanity test ? Well, I found it a bit funny :-) I assume you wanted to check the
> file, but there's no getter, so I'm in favour of getting rid of this.

Still better then Assert.assertTrue(true)....
Otherwise I agree...

>
>> +
>> +    }
>> +
>> +    @Test
>> +    public void testNullJnlpFile(){
>> +        Exception ex = null;
>> +        try{
>> +        SecurityDesc securityDesc = new SecurityDesc(null, SecurityDesc.SANDBOX_PERMISSIONS,
>> "hey!");
>> +        }catch(Exception eex){
>> +            ex=eex;
>> +        }
esourcesDesc;
>> +import net.sourceforge.jnlp.SecurityDesc;
>> +
>> +/**
>> + *
>> + * @author jvanek
>> + */
>
> Snip these lines

damn. done...
> Maybe you could configure NetBeans to add the Red Hat copyright header and not add these lines ? :-))

YAh.. aafter years of errors :-/
>
>> +public class DummyJNLPFile extends JNLPFile {
>> +
>> +
>> +    public static final URL JAR_URL;
>> +    public static final URL CODEBASE_URL;
>> +
>> +    static {
>> +        try {
>> +            JAR_URL = new URL("http://icedtea.classpath.org/netx/about.jar");
>> +            CODEBASE_URL = new URL("http://icedtea.classpath.org/netx/");
>> +        } catch (Exception ex) {
>> +            throw new RuntimeException(ex);
>> +        }
>> +    }
>> +
>> +
>> +    @Override
>> +    public ResourcesDesc getResources() {
>> +        return new ResourcesDesc(null, new Locale[0], new String[0], new String[0]);
>> +    }
>> +
>> +    @Override
>> +    public URL getCodeBase() {
>> +        return CODEBASE_URL;
>> +    }
>> +
>> +    @Override
>> +    public SecurityDesc getSecurity() {
>> +        return new SecurityDesc(this, SecurityDesc.SANDBOX_PERMISSIONS, null);
>> +    }
>> +
>> +}
>
> Almost acceptable :-)
>
> Happy hacking,
> -Adam

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixedRegression_3.patch
Type: text/x-patch
Size: 20490 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130424/9370a45b/fixedRegression_3.patch