Regression in itw from Tue Mar 26

Jiri Vanek jvanek at redhat.com
Wed Apr 24 09:37:16 PDT 2013


On 04/24/2013 06:34 PM, Adam Domurad wrote:
>> +    @Test
>> +    public void testNotNullJnlpFile(){
>> +        SecurityDesc securityDesc = new SecurityDesc(new DummyJNLPFile(),
>> SecurityDesc.SANDBOX_PERMISSIONS, "hey!");
>> +        Assert.assertNotNull("securityDesc should not be ",securityDesc);
>> +
>> +    }
>
> Huh. Why is this still in ? Sorry, I can't support superstitious coding.
>
> At least drop the assert if you want a constructor sanity check.

No. I would like to keep it inside even with  assert.
The code inside the constructor can change later. Eg some dummy jnl file will be tried to be created 
and used into if argument is null.

I would like to have it recorded.

>
> Push without this please. Otherwise good.
>
> Happy hacking,
> -Adam




More information about the distro-pkg-dev mailing list