[rfc][icedtea-web] PR1271, Handle 'javascript:' urls, with tests

[Adam Domurad]

On 08/06/2013 05:26 PM, Jacob Wisor wrote:
> Hello!

Hi! Can you please try and find a mailer that properly responds to
emails ? It is quite hard to follow your responses.
>
> My usual nit picks:
>
>> +    static private void installDummyJavascriptProtocolHandler() {
>> +        try {
>> +            Field handlersField = URL.class.getDeclaredField("handlers");
>> +            handlersField.setAccessible(true);
>> +
>> +            @SuppressWarnings("unchecked")
>> +            Hashtable<String, URLStreamHandler> handlers = (Hashtable<String,URLStreamHandler>)handlersField.get(null);
> You can make the compiler happy by checking the return value with the instanceof operator. ;)

No you cannot, it is complaining that it is impossible to tell Hashtable
and Hashtable<String,URLStreamHandler> apart, which is just how Java works.

>> +
>> +            // Place an arbitrary handler, we only need the URL construction to not error-out
>> +            handlers.put("javascript", new sun.net.www.protocol.http.Handler());
>> +        } catch (Exception e) {
> Uhh ahh, there are good reasons not to do this :)

Indeed, unless there are no better ideas. There isn't exactly an API for
doing this.

Happy hacking,
-Adam