/hg/icedtea-web: Removed HTTP 400 BAD REQUEST as it was unneeded...

[aazores at icedtea.classpath.org]

changeset 5d7b3a507709 in /hg/icedtea-web
details: http://icedtea.classpath.org/hg/icedtea-web?cmd=changeset;node=5d7b3a507709
author: Andrew Azores <aazores at redhat.com>
date: Tue Aug 13 13:54:10 2013 -0400

	Removed HTTP 400 BAD REQUEST as it was unneeded (test server won't be checking anyway)


diffstat:

 ChangeLog                                                               |  6 ++++++
 tests/test-extensions-tests/net/sourceforge/jnlp/TinyHttpdImplTest.java |  8 --------
 tests/test-extensions/net/sourceforge/jnlp/TinyHttpdImpl.java           |  2 --
 3 files changed, 6 insertions(+), 10 deletions(-)

diffs (57 lines):

diff -r e71b4c00d418 -r 5d7b3a507709 ChangeLog
--- a/ChangeLog	Mon Aug 12 10:00:49 2013 -0400
+++ b/ChangeLog	Tue Aug 13 13:54:10 2013 -0400
@@ -1,3 +1,9 @@
+2013-08-13  Andrew Azores  <aazores at redhat.com>
+	* tests/test-extensions/net/sourceforge/jnlp/TinyHttpdImpl.java: no longer
+	sends HTTP 400 BAD REQUEST messages
+	* test/test-extensions-tests/net/sourceforge/jnlp/TinyHttpdImplTest.java:
+	removed "bad request" test
+
 2013-08-12  Andrew Azores  <aazores at redhat.com>
 	* tests/test-extensions/net/sourceforge/jnlp/TinyHttpdImpl.java: refactored
 	* tests/test-extensions/net/sourceforge/jnlp/ServerLauncher.java:
diff -r e71b4c00d418 -r 5d7b3a507709 tests/test-extensions-tests/net/sourceforge/jnlp/TinyHttpdImplTest.java
--- a/tests/test-extensions-tests/net/sourceforge/jnlp/TinyHttpdImplTest.java	Mon Aug 12 10:00:49 2013 -0400
+++ b/tests/test-extensions-tests/net/sourceforge/jnlp/TinyHttpdImplTest.java	Tue Aug 13 13:54:10 2013 -0400
@@ -17,7 +17,6 @@
 public class TinyHttpdImplTest {
 
     private static final String HTTP_OK = "HTTP/1.0 200 OK";
-    private static final String HTTP_400 = "HTTP/1.0 400 Bad Request";
     private static final String HTTP_404 = "HTTP/1.0 404 Not Found";
     private static final String HTTP_501 = "HTTP/1.0 501 Not Implemented";
     private static final String CONTENT_JNLP = "Content-Type: application/x-java-jnlp-file";
@@ -185,13 +184,6 @@
     }
 
     @Test
-    public void BadMethodTest() throws Exception {
-        String head = getTinyHttpdImplResponse("BADMETHOD", "/simpletest1.jnlp");
-
-        Assert.assertTrue("Status should have been " + HTTP_400, head.trim().equals(HTTP_400));
-    }
-
-    @Test
     public void NotSupportingHeadRequest() throws Exception {
         boolean headRequestSupport = mServer.isSupportingHeadRequest();
         mServer.setSupportingHeadRequest(false);
diff -r e71b4c00d418 -r 5d7b3a507709 tests/test-extensions/net/sourceforge/jnlp/TinyHttpdImpl.java
--- a/tests/test-extensions/net/sourceforge/jnlp/TinyHttpdImpl.java	Mon Aug 12 10:00:49 2013 -0400
+++ b/tests/test-extensions/net/sourceforge/jnlp/TinyHttpdImpl.java	Tue Aug 13 13:54:10 2013 -0400
@@ -60,7 +60,6 @@
 public class TinyHttpdImpl extends Thread {
 
     private static final String CRLF = "\r\n";
-    private static final String HTTP_BAD_REQUEST = "HTTP/1.0 " + HttpURLConnection.HTTP_BAD_REQUEST + " Bad Request" + CRLF;
     private static final String HTTP_NOT_IMPLEMENTED = "HTTP/1.0 " + HttpURLConnection.HTTP_NOT_IMPLEMENTED + " Not Implemented" + CRLF;
     private static final String HTTP_NOT_FOUND = "HTTP/1.0 " + HttpURLConnection.HTTP_NOT_FOUND + " Not Found" + CRLF;
     private static final String HTTP_OK = "HTTP/1.0 " + HttpURLConnection.HTTP_OK + " OK" + CRLF;
@@ -125,7 +124,6 @@
 
                     if (!isHeadRequest && !isGetRequest) {
                         ServerAccess.logOutputReprint("Received unknown request type " + request);
-                        writer.writeBytes(HTTP_BAD_REQUEST);
                         continue;
                     }