[rfc][icedtea-web] PR1271, Handle 'javascript:' urls, with tests

Adam Domurad adomurad at redhat.com
Mon Aug 19 07:38:48 PDT 2013


On 08/16/2013 11:51 AM, Andrew Azores wrote:
> On 08/07/2013 10:08 AM, Adam Domurad wrote:
>>
>>>> +
>>>> +            // Place an arbitrary handler, we only need the URL construction to not error-out
>>>> +            handlers.put("javascript", new sun.net.www.protocol.http.Handler());
>>>> +        } catch (Exception e) {
>>> Uhh ahh, there are good reasons not to do this :)
>> Indeed, unless there are no better ideas. There isn't exactly an API for
>> doing this.
> 
> Is there a more specific Exception type that could be caught?

There are several, I can catch them all explicitly if you'd like. The
exception should probably be logged even not in debug, come to think of it.

> 
>>
>> Happy hacking,
>> -Adam
> 
> I think this looks good though.

Is that an approval ? :-)

> 
> Thanks,
> 

Happy hacking,
-Adam



More information about the distro-pkg-dev mailing list