Re: [rfc][icedtea-web] Temporary files location chooser cleanup

[Jacob Wisor]

"Andrew Azores"<aazores at xxxxxxxxxx> wrote:
> On 08/25/2013 07:30 AM, Jacob Wisor wrote:
> > Ping?
> >
> > "Jacob Wisor"<gitne at excite.co.jp> wrote:
> >> Hello,
> >>
> >> * Made temporary files location JFileChooser open at the currently specified location
> >> * Made temporary files location JFileChooser display a helpful title
> >> * Removed misleading "All Files" file filter from JFileChooser
> >> * Added new message to resources for JFileChooser's choose button
> >> * Fixed a few inconsistent messages in resource files
> >>
> >> @Jiri
> >> Please add a cs translation for the new "TIFPFileChooserChooseButton" message.
> >>
> >> Regards,
> >> Jacob
> 
> Personally I don't really like the "Choose" label on the button, I would
> prefer if it was left as "Open". It just seems more standard for a file
> browser popup. But I'm not really opposed to the change if you insist on
> it. Everything else looks good to me.

I would also rather leave JFileChooser's default "Open" button unchanged, but the swing framework does not use the native system's own open file dialog that is usually localized. As for now, OpenJDK supports 5 languages only, hence for languages that are supported by IcedTea-Web but not by OpenJDK the user is going to see an oddly outstanding English open file dialog in an otherwise fully localized user-experience.
Furthermore, the action that is ought to be done is not openning a file or directory but actually selecting or choosing a directory, so changing the button's text to "Choose" - even in English - seems reasonable.
I do not insist to keep it the proposed way, but imho there are sufficient reasons to do it.

Thank you for reviewing.
Jacob