[rfc][icedtea-web] Fix CacheReproducerTest

[Andrew Azores]

On 08/29/2013 09:59 AM, Jiri Vanek wrote:
> On 08/29/2013 03:13 PM, Andrew Azores wrote:
>> Changelog:
>> * 
>> tests/reproducers/signed/CacheReproducer/testcases/CacheReproducerTest.java: 
>> (icedteaDir) field
>> updated to reflect new ITW cache location from XDG spec. 
>> (clearCacheUnsucessfully) checks for
>> correct "can not clear the cache" error message
>>
>> Not much going on here, really :). This is the start of my effort to 
>> stabilize reproducers. Looks
>> like I got lucky with my first set to fix, because this turned out to 
>> be very very easy. There is
>> one "KnownToFail" test in here that occasionally passes, so I will 
>> also look into that, but these
>> two small changes stand on their own to fix the rest of the tests at 
>> least.
>>
>> Thanks,
>>
>
> Nice catch. My wrong I overlooked the hard coded path.
>
> However - the test case can see the libraries, and the real 
> cache(/config) path is now in Defaults. So I think it would be better 
> to get rid of this hard coded path completely and replace by 
> variable[1] (there was no variable in time of this test writing). This 
> variable should be filled correctly no meter if custom XDG variable i 
> set.
>
>
> J.
>
> [1]http://icedtea.classpath.org/hg/icedtea-web/file/420d72e5cee7/netx/net/sourceforge/jnlp/config/Defaults.java#l58 
>
>
> If you do not wont to use the full path (but why not), then maybe just 
> http://icedtea.classpath.org/hg/icedtea-web/file/420d72e5cee7/netx/net/sourceforge/jnlp/config/DeploymentConfiguration.java#l53
>

Like this you mean? I had to add the test to the same package as the 
Defaults class since that variable is set to default visibility, not public.

Thanks,

-- 
Andrew A

-------------- next part --------------
A non-text attachment was scrubbed...
Name: CachReproducerTest.patch
Type: text/x-patch
Size: 2862 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130829/060923a6/CachReproducerTest.patch