[rfc][icedtea-web] Fix CacheReproducerTest

[Omair Majid]

On 08/30/2013 11:20 AM, Andrew Azores wrote:
> On that note - Jiri, wouldn't using the value from Defaults not take
> into account the user changing the cache location using itweb-settings?
> Perhaps it makes more sense to use DeploymentConfiguration here to
> ensure that the reproducer test is actually testing using the cache dir
> that the user expects to use as a cache dir? This way if you've never
> changed the cache location in itweb-settings then you get the same path
> as taking it from Defaults would give you, but it does still also
> respect if you've changed the cache location.

This is sort of hand-wavy, but it might be a good idea to keep
reproducers predictable. When the reproducers are run, they should use a
'known' configuration and check for exact paths. A mistake in code (a
typo in one of the configuration defaults, for example) should be
detected by the reproducers.

Allowing a user's configuration to affect the test would surely make
things much less predictable - the opposite of what you want in a good
automated test.

Thanks,
Omair
-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681