[rfc][icedtea-web] Show cache size in itweb-settings (PR1604)

[Andrew Azores]

I thought of that too but it seemed like the unit should be pretty universal on these labels. I'm not opposed to moving it into the Messages files though.

Andrew A

----- Original Message -----
From: "Omair Majid" <omajid at redhat.com>
To: "Andrew Azores" <aazores at redhat.com>
Cc: "IcedTea" <distro-pkg-dev at openjdk.java.net>
Sent: Thursday, December 5, 2013 4:00:44 PM
Subject: Re: [rfc][icedtea-web] Show cache size in itweb-settings (PR1604)

Hi,

* Andrew Azores <aazores at redhat.com> [2013-12-05 15:57]:
> Very very simple patch here. The Temporary Internet Files Panel
> displays a cache size slider, but there's no indication of what
> units are in use here. Evidently it's megabytes, so I've added this
> unit to the label so that it's actually clear how large the cache
> will be allowed to grow.

> +        JLabel lCacheSize = new JLabel(Translator.R("TIFPCacheSize") + " (MB) :");

I think it makes more sense to add the '(MB)' string to the localized
text. Not all languages will have (MB) after the cache size string. What
do you think?

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681