[rfc][icedtea-web] Show cache size in itweb-settings (PR1604)

Jiri Vanek jvanek at redhat.com
Fri Dec 6 00:26:57 PST 2013

On 12/06/2013 12:10 AM, Jacob Wisor wrote:
> Andrew Azores schrieb:
>> I thought of that too but it seemed like the unit should be pretty universal on these labels. I'm not opposed to moving it into the Messages files though.

Yes Andrew, please try to follow.
> In fact, "MB" is not an internationally acknowledged unit symbol. The IEC has defined "MiB" for megabyte (2^20 bytes). Btw, "MB" is commonly rather understood as 10^6 bytes. Please read Wikipedia articles on the definition of units of data storage and their proper writing.
> If this is going to be fixed, I would rather insist to do it right. Either the IEC way with proper ISO number formatting or the localized way with a locale specific unit symbol and number formatting.
> Omair is right, this has to be done correctly, otherwise it is a waste of effort because there are still other locale specific data renderings in IcedTea-Web pending to be fixed.
>> ----- Original Message -----
>> From: "Omair Majid" <omajid at redhat.com>
>> To: "Andrew Azores" <aazores at redhat.com>
>> Cc: "IcedTea" <distro-pkg-dev at openjdk.java.net>
>> Sent: Thursday, December 5, 2013 4:00:44 PM
>> Subject: Re: [rfc][icedtea-web] Show cache size in itweb-settings (PR1604)
>> Hi,
>> * Andrew Azores <aazores at redhat.com> [2013-12-05 15:57]:
>>> Very very simple patch here. The Temporary Internet Files Panel
>>> displays a cache size slider, but there's no indication of what
>>> units are in use here. Evidently it's megabytes, so I've added this
>>> unit to the label so that it's actually clear how large the cache
>>> will be allowed to grow.
>>> + JLabel lCacheSize = new JLabel(Translator.R("TIFPCacheSize") + " (MB) :");
>> I think it makes more sense to add the '(MB)' string to the localized
>> text. Not all languages will have (MB) after the cache size string. What
>> do you think?
>> Thanks,
>> Omair

More information about the distro-pkg-dev mailing list