[rfc][icedtea-web] Fix for PR1592 and jnlp applets/applications

[Jiri Vanek]

On 12/11/2013 04:50 PM, Jiri Vanek wrote:
> On 12/09/2013 05:25 PM, Andrew Azores wrote:
>> Hi,
>>
>> The fix for PR1592 currently only affects plugin applets. The attached patch fixes this so that it
>> also enables the same functionality when launching from JNLP, as well as the fix for the reproducer
>> to expect this behaviour.
>>
>> Thanks,
>>
>
>
> hi!
>
> The change is really simple, just diff is messy. For this kind of patch is good to ignore whitepsaces.
>
> you :  SecurityDesc jarSecurity = file.getSecurity(); -> changed to   SecurityDesc jarSecurity;
>
> I'm wonderinng if  the original value of file.getSecurity(); was used
>
>
> then you removed if (file instanceof PluginBridge) { condition in favour of
>
>           AppVerifier appVerifier;
>              if (file instanceof PluginBridge) {
>                  appVerifier = new PluginAppVerifier();
>              } else {
>                  appVerifier = new JNLPAppVerifier();
>              }
>              try {
>                  if (JarCertVerifier.isJarSigned(jarDesc, appVerifier, tracker)) {
>
>
> yes, give sense:)
>
> If you are sure the "  SecurityDesc jarSecurity = file.getSecurity(); -> changed to   SecurityDesc
> jarSecurity;" will not npe, then ok for head.

together with enhanced tests.

>
> J.