[rfc][icedtea-web] jnlpruntime.config changed to singleton

[Andrew Azores]

On 12/17/2013 11:26 AM, Jiri Vanek wrote:
> On 12/17/2013 04:19 PM, Andrew Azores wrote:
>> On 12/16/2013 01:04 PM, Jiri Vanek wrote:
>>> Hi!
>>>
>>> this simple patch is changing behaviour of jnlpruntime.config to be 
>>> real singleton independent on
>>> rest of config.
>>>
>>> The patch is pretty stright forward, except :
>>>
>>>
>>> netx/net/sourceforge/jnlp/config/DeploymentConfiguration.java's
>>>
>>> +    private ConfigurationException loadingException = null;
>>> +
>>> +    public void setLoadingException(ConfigurationException ex) {
>>> +        loadingException = ex;
>>> +    }
>>> +
>>> +    public ConfigurationException getLoadingException() {
>>> +        return loadingException;
>>> +    }
>>>
>>>
>>>
>>>
>>> and its usage:
>>>
>>>         if (isApplication && 
>>> getConfiguration().getLoadingException() != null) {
>>>                 JNLPRuntime.exit(1);
>>>         }
>>>
>>> For head, I'm thinking to not exit here, and continue with default 
>>> runtime, and visible
>>> warning/exception
>>>
>>>
>>> Also this pathc is simple enough that I'm inclined to backport it to 
>>> 1.4...
>>>
>>>
>>> J.
>>
>> Hi,
>>
>> This looks good to me, except for minor indentation/formatting in the 
>> getConfiguration() method.
>
> And the exiting for head?
>

It sounds reasonable I think. I don't see anything wrong with the idea - 
but that doesn't necessarily mean it is a good one :)

>> Backport sounds okay too.
>>
>> Thanks,
>>
>

Thanks,

-- 
Andrew A