[rfc][icedtea-web] Minor addition to html-gen.sh

[Jiri Vanek]

On 12/23/2013 06:50 PM, Andrew Azores wrote:
> Hi,
>
> ChangeLog:
> * html-gen.sh: Added hyperlinks for revisions in generated ChangeLog
>
> This patch adds revision hyperlinks to the generated ChangeLog html used for javaws -about. The revisions should match up with the ChangeLog entry they're placed next to so long as the ChangeLog is properly kept in sync with the actual hg history. The script just assumes that the last 10 entries in hg log correspond 1:1 to the last 10 entries in the plain ChangeLog file. The script also uses the remote URL of the current repo to figure out where to link revisions, so it should still work and link to the correct revisions once the script is branched out of hg/icedtea-web and into hg/release/icedtea-web-1.5, for example.
>
> Thanks,
>
> Andrew A


The code is ok, you are shell master :)


There was task (created and assigned to himself by Pavel, but he is to lazy to act O:)  to move our luncher.in from bashism to general shell. Do you wont to take it?


Several general hints:


"...sions should match up with the ChangeLog entry they're placed next to so long as the ChangeLog is properly kept in sync w..."
   - thsi is  generally not true for head, but should be true for branches. Eg right now the head have one minor commit one push before head.
     Anyway I'm against to fix this, as this will made code unnecessary complex, and current functionality is more then enough (is great anough :)

On current head, the first link is broknen:
generated http://icedtea.classpath.org/hg/icedtea-web/rev/4c1610ee5941 against real http://icedtea.classpath.org/hg/icedtea-web/rev/17818bc7aba3. Not sure how it happnede, but again not worthy to fix imho (it lead user to repo anyway)

feel free to elaborate as you wish.

"... out of hg/icedtea-web and into hg/release/icedtea-web-1.5..." .. nice :)

Only one "against the immediate push" : I dont think the revision text is worthy. I would use current date-name as link text, and href same as have current revision text.


One thing to think about, or for next push or whatever - There is hardcoded 10 items in chnaglog -  Imho the whole changelog since last release is worthy. So 1.5 will have whole changelog since 1.4 branching. 1.5.1 will have whole chnagelog since 1.5(.0)... and os on. I' afraid the  hgtags file is only helper here. Is it to hard to implement?


Thanx! Nice patch!


J.