[rfc][icedtea-web] Provide names for all unnamed threads

[Adam Domurad]

On 02/01/2013 03:36 AM, Jiri Vanek wrote:
> On 01/31/2013 10:49 PM, Adam Domurad wrote:
>> Simple patch, but very nice for debugging/ tooling. This will make it 
>> easier to track down specific threads while debugging or using 
>> Thermostat. An absolute must IMO for sane debugging of problems 
>> occurring in multiple threads.
>
> Agree, after one question patch is ok for head and should go also to 
> branches to avoid future patching conflicts.

I will push as-is, OK ?

>>
>> 2013-XX-XX  Adam Domurad <adomurad at redhat.com>
>>
>>      Name threads for easier debugging/tooling. Remove 2 erroneous
>>      VoidPluginCallRequest header comments.
>>      * netx/net/sourceforge/jnlp/NetxPanel.java:
>>      Provide name for thread that calls (run).
>>      * netx/net/sourceforge/jnlp/runtime/JNLPRuntime.java:
>>      Provide name for shutdown hook thread.
>>      * plugin/icedteanp/java/sun/applet/PluginMessageConsumer.java:
>>      Remove erroneous VoidPluginCallRequest comment. Provide name for
>>      ConsumerThread thread.
>>      * plugin/icedteanp/java/sun/applet/PluginMessageHandlerWorker.java:
>>      Provide name for worker thread.
>>      * plugin/icedteanp/java/sun/applet/PluginStreamHandler.java:
>>      Remove erroneous VoidPluginCallRequest comment. Provide name for
>>      stream listener thread.
>>
> ...
>
>> +++ b/plugin/icedteanp/java/sun/applet/PluginMessageConsumer.java
>> @@ -1,4 +1,4 @@
>> -/* VoidPluginCallRequest -- represent Java-to-JavaScript requests
>> +/*
> VoidPluginCallRequest is supicious,
>
> However this, represent Java-to-JavaScript requests looks like it 
> could be right. Asking just for clarification. as it can be useful if 
> it is correct.

This is definitely not right, it is a comment meant for another class.
PluginMessageConsumer is not javascript specific nor does it 'represent 
requests'.

>
>>      Copyright (C) 2008  Red Hat
>>
>>   This file is part of IcedTea.
>> @@ -131,6 +131,10 @@ class PluginMessageConsumer {
>>
>>       protected class ConsumerThread extends Thread {
>>
>> +        public ConsumerThread() {
>> +            super("PluginMessageConsumer.ConsumerThread");
>> +        }
>> +
>
> J.

-Adam