[rfc][icedtea-web] Ensure JarFile handles do not leak, introduce closeSilently utility
Adam Domurad
adomurad at redhat.com
Wed Feb 13 08:43:46 PST 2013
On 02/12/2013 04:55 PM, Adam Domurad wrote:
> This squelches some Eclipse warnings.
>
>> 2013-XX-XX Adam Domurad <adomurad at redhat.com>
>>
>> Ensure JarFile handles do not leak.
>> * netx/net/sourceforge/jnlp/util/StreamUtils.java:
>> New, introduces 'closeSilently'. Ignores nulls & exceptions when
>> closing.
>> * netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java:
>> Ensure StreamUtils.closeSilently or close is called for each
>> JarFile.
OK that patch had a bug in it, and was probably too paranoid. This ones
better.
Turns out JNLPClassLoader already had a closeStreams utility function.
2013-XX-XX Adam Domurad <adomurad at redhat.com>
Ensure JarFile handles do not leak.
* netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java:
Ensure close is called for each JarFile.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: closeJarFiles2.patch
Type: text/x-patch
Size: 2194 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130213/5c7e72fe/closeJarFiles2.patch
More information about the distro-pkg-dev
mailing list