RFC: Fix for PR1260
Deepak Bhole
dbhole at redhat.com
Mon Jan 21 08:24:48 PST 2013
* Andrew Hughes <gnu.andrew at redhat.com> [2013-01-21 09:55]:
>
>
> ----- Original Message -----
> > * Andrew Hughes <gnu.andrew at redhat.com> [2013-01-18 15:35]:
> > >
> > >
> > > ----- Original Message -----
> > > > Hi,
> > > >
> > > > This patch fixes PR1260: IcedTea-Web should not rely on GTK
> > > >
> > > > ChangeLog:
> > > > 2013-01-16 Deepak Bhole <dbhole at redhat.com>
> > > >
> > > > PR1260: IcedTea-Web should not rely on GTK
> > > > * Makefile.am: Remove GTK includes and links
> > > > * acinclude.m4: Remove check for GTK libs
> > > > * plugin/icedteanp/IcedTeaJavaRequestProcessor.h: Removed
> > > > gtk.h
> > > > include
> > > > and added unistd include (for usleep) which gtk.h brought in
> > > > before
> > > > * plugin/icedteanp/IcedTeaNPPlugin.cc: Remove GTK dialog
> > > > shown
> > > > when java
> > > > is not found
> > > > * plugin/icedteanp/IcedTeaNPPlugin.h: Removed gtk.h include
> > > >
> > > >
> > > > OK for HEAD and 1.3? 1.2 currently links against GTK2 only, and
> > > > since
> > > > there
> > > > have been no requests for GTK3 there, I think we should leave it
> > > > alone.
> > > >
> > > > Cheers,
> > > > Deepak
> > > >
> > >
> > > So what happens now when Java isn't found? Most users running a
> > > browser
> > > aren't going to see a message printed to stderr, are they?
> >
> > Right, not on stderr. It will still be logged into ~/.xsession-errors
> > though.
> >
> > Cheers,
> > Deepak
> >
> > > --
> > > Andrew :)
> > >
> > > Free Java Software Engineer
> > > Red Hat, Inc. (http://www.redhat.com)
> > >
> > > PGP Key: 248BDC07 (https://keys.indymedia.org/)
> > > Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
> > >
> >
>
> Doesn't the browser provide a way of passing messages to the user?
>
Not that I am aware of. We do send a error back during initialization to
the browser, but that return code has no option to attach a message or
to show anything to the user via a dialog.
If anyone knows of a way to do it via NPAPI though (browser agnostic), I
am definitely +1 for it.
Cheers,
Deepak
> I doubt most novice users are going to look in ~/.xsession-errors either.
> --
> Andrew :)
>
> Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
>
> PGP Key: 248BDC07 (https://keys.indymedia.org/)
> Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
>
More information about the distro-pkg-dev
mailing list