[rfc][icedtea-web] Removing applications tab in jawas-about
Andrew Azores
aazores at redhat.com
Fri Jul 5 13:53:30 PDT 2013
I made a fresh set of patches attached here because my workspace was
getting a little dirty and also out of date. Changelog is the same for
each patch file though. The new one, "last.patch," just removes all the
old extras.jar stuff essentially. All the more important changes are
still in the other patches, same as last time.
On 07/02/2013 09:33 AM, Jiri Vanek wrote:
> Hi!
> nice progress! Especially headless one working and cut news/changelog
> are nice improvements.
>
> General comments:
> - remove applications.html (but url to our set of manual reproducers
> with notes how and why to add new one should be mentioned somewhere)
> - drop notes
> - dropping of jamIcon is up to you, I'm for usage of it in new
> authors;)
It's back, I think it does make the Authors page look nicer :)
> - refactor about
> - I think you can reuse some text, but it it should be read from
> properties
> - also you can reuse some parts from notes and applications, but
> instead of individual application proper links to icedtea web pages
> should be provided
> - also it can be worthy to include some image in main about - eg
> shrinken logo of splash image? Or to draw the vector from which is
> hardcoded?
> - new text have to be added to "new" about - to describe
> IcedTea-web properly (also worthy to mention plugin, itw-settings,
> homepage(s!), purpose of new tabs and so on...
> - actually the new colourful main about have the same importance as
> the new nice generated files you already provided
> - you can reuse already provided splash logo, or (probably
> better) use your own, derived one same palce as other resources. Just
> keep in mind that those "new logo" and current splash should be very
> similar.
Added some more to it, but not sure what else to do here.
> - some indentation/mark-up both for headless/head"full" versions
Added!
> - centre the dialogue (tehre is utility method for such a stuff)
This too :)
> - what about renaming of Copying into GPLv2 License ? (just $0.02)
I like this suggestion. I've renamed it to just "GPLv2" so that the
tab's name isn't too long compared to others.
> - btw about, Authors, Changelog, News... All the tabs should now be
> read from resources too.
>
> Don't take me wrong, this is nice work and most of above are just
> small nits and some can be done as separated chnageset.
>
> - Big nit - redesign the dialogue completely? So it will be "nice" ?
> - I'm in favour hardcoded (localisable) main "about" screen and
> then some better swapping to (more customised to its purpose) three
> underlying tabs. However, unless you really wont this have low
> priority definitely should go as separate chnageset.
> - nitpickers note - see other apps about dialogues :) Itw is really
> few decades behind....
Changed it up quite a bit in this version but not sure how much better
it really is. I think it looks nicer at least. It doesn't handle
resizing quite as nicely anymore however and I'm really not a Swing guru
(or any kind of UI for that matter) and am not sure what to do about it.
>
>
> around here will go the centring of dialogue
It's in there now, somewhere. :)
>
>> + JFrame frame = new JFrame();
>> + frame.add(new AboutDialog());
>> + frame.setSize(640, 480);
>> + frame.setVisible(true);
>> + frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
>> + }
>>
>> + private static final String itwInfoMessage = ""
>> + + name + " " + version
>> + + "\n"
>> + + R("BAboutITW")
>> + + "\n"
>> + + R("BFileInfoAuthors")
>> + + "\n"
>> + + R("BFileInfoNews")
>> + + "\n"
>> + + R("BFileInfoCopying");
>
> here will come the indentation eg
> icedtea-web 1.5pre+r87c9fc859a21+
> === icedtea-web wiki page:
> http://icedtea.classpath.org/wiki/IcedTea-Web ===
> IcedTea web is free implementation of jnlp client and java plugin
> * Names and email addresses of contributors to this project can be
> found in the file AUTHORS.
> * News about this project can be found in the file NEWS.
> * The license of this project can be found in the file COPYING.
>
> maybe more full path to this files can be mentioned. Also the man page
> and -help swithc can be mentioned
>
> just nits moreower. nice as it is!
Indentation for the "headless" message tweaked and some more info added
in Messages.properties for this.
>
>
>
>> +
>> private static final String miniLicense = "\n"
>> + " netx - an open-source JNLP client.\n"
>> + " Copyright (C) 2001-2003 Jon A. Maxwell (JAM)\n"
>> @@ -137,8 +152,21 @@ public final class Boot implements Privi
>> System.exit(0);
>> }
>>
>> - if (null != getOption("-about"))
>> - System.out.println(aboutMessage);
>> + if (null != getOption("-about")) {
>> + if (null != getOption("-headless")) {
>> + System.out.println(itwInfoMessage);
>> + System.exit(0);
>> + } else {
>> + System.out.println(aboutMessage);
>> + try {
>> + AboutDialog.display();
>> + return;
>> + } catch (IOException e) {
>> + System.out.println(R("BLaunchAboutFailure"));
>> + e.printStackTrace();
>> + }
>> + }
>> + }
>
> I would probably go by more sure way:
>
> if (null != getOption("-about")) {
> System.out.println(itwInfoMessage);
> if (null != getOption("-headless")) {
> System.exit(0);
> } else {
> // System.out.println(aboutMessage); - this should now
> not be necessary when itwInfoMessage is showed for both?
> try {
> AboutDialog.display();
> return;
> } catch (Exception e) {
> System.out.println(R("BLaunchAboutFailure"));
> throw new RuntimeException(e); //let it die quicly
> }
> }
> }
>
Good idea as well, this also got changed.
>
>
>> install-data-local:
>> - ${mkinstalldirs} -d $(DESTDIR)$(mandir)/man1
>> + ${mkinstalldirs} -d $(DESTDIR)$(mandir)/man1
>
> There slipped empty chars to the end of the line. This is not allowed.
Fixed, thank you for catching this!
>> -stamps/netx.stamp: netx-source-files.txt
>> stamps/bootstrap-directory.stamp
>> +stamps/netx-html-gen.stamp:
>> + (cd $$NETX_SRCDIR/..; \
>> + mkdir -p html-gen; \
>> + cp AUTHORS NEWS COPYING ChangeLog html-gen/; \
>> + cd html-gen/; \
>> + for FILE in NEWS AUTHORS COPYING ChangeLog; \
>> + do \
>> + sed -e "s/\t//g" -e "s/\&/\&/g" -e "s/
>> /\ \ /g" -e "s/</\</g" -e "s/>/\>/g" -e "s/$$/<br>/g"
>> "./$$FILE"> "./$$FILE.html"; \
>> + done; \
>> + sed -i '4i<center>' AUTHORS.html; \
>> + echo "</center>">> AUTHORS.html; \
>> + for FILE in NEWS.html ChangeLog.html; \
>> + do \
>> + mv $$FILE "$$FILE.old"; \
>> + COUNTER=0; \
>> + while read LINE; \
>> + do \
>> + if [[ $$FILE == "NEWS.html" ]]; \
>> + then \
>> + if [[ $$LINE =~ New\ in\ release* ]]; \
>> + then \
>> + COUNTER=$$(( $$COUNTER + 1 )); \
>> + fi; \
>> + if [[ $$COUNTER -gt 2 ]]; \
>> + then \
>> + break; \
>> + fi; \
>> + else \
>> + if [[ $$LINE =~
>> [[:digit:]]{4}-[[:digit:]]{2}-[[:digit:]]{2}* ]]; \
>> + then \
>> + COUNTER=$$(( $$COUNTER + 1 )); \
>> + fi; \
>> + if [[ $$COUNTER -gt 10 ]]; \
>> + then \
>> + break; \
>> + fi; \
>> + fi; \
>> + echo "$$LINE">> $$FILE; \
>> + done< "$$FILE.old"; \
>> + rm $$FILE.old; \
>> + done)
>> + ${INSTALL_DATA} $(NETX_SRCDIR)/../html-gen/*.html
>> $(NETX_RESOURCE_DIR)
>> + rm -r $(NETX_SRCDIR)/../html-gen/
>> + mkdir -p stamps
>> + touch $@
>> +
>
>
> well well well.. this is THE CODE :) My deepes credits that this works :)
> If you will smuggle some markup into this, then it would be nice, and
> it will be alowed to go in.
> There is strong disadvantage that you can not use internalisation.
> Also the miantainability of this code is quite pure.
>
>
> Anyway this cango in with markup, assuming it works.
This grew a little more now... email addresses, eg <aazores at redhat.com>,
get turned into "mailto" links now. Actually since it is HTML-escaped
first, it would be "<aazores at redhat.com>" that gets turned into a
mailto. Similarly, http(s) URLs are automatically turned into
hyperlinks. I've done both of those because I had hyperlinks added to
the new about.html, and added the ability to click these in
HTMLPanel.java. It seemed natural to have the rest of the tabs also
contain clickable content.
>
>
> The idea how it can be done by different way - just note - fdifferent
> - not better.
>
> You can have soem small class in net.sourceforge.jnlp.about, which
> will have main class. This method will be already compiled with rest
> of netx in time of generation, so you will be able to run this class.
> This class can serve as small program - transformer from txt fiels
> into html file.
> You will have much more fredom in generation, and it will be much more
> readable, and localisation would be possible to be used (maybe [me do
> not insists]). But will be maybe rocket luncher instead of cross bow...
> Also I'm not sure how it willbe transparrent for others...
>
> Actually jsut crossed across my mind that all this "localisation"
> leads back to you "runtime" generation which I really do not wont to
> allow. So please do not follow blindly mi nits in this review.
Maybe there would still be a way to localize the content, but I don't
know how to do it really. Applying it to the generated HTML sounds
sketchy, but applying it to the plaintext beforehand sounds like a
pretty major change compared to the current way it works, which as you
can see is basically just a bunch of sed commands.
>
>
>
> Really nice wok!
> I'm galad to see it grow!
>
> J.
Thank you :)
Andrew A
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix.patch
Type: text/x-patch
Size: 14793 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130705/460ff4e6/fix.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: last.patch
Type: text/x-patch
Size: 14558 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130705/460ff4e6/last.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Makefile.am.patch
Type: text/x-patch
Size: 8742 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130705/460ff4e6/Makefile.am.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: resources.patch
Type: text/x-patch
Size: 6629 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130705/460ff4e6/resources.patch
More information about the distro-pkg-dev
mailing list