[rfc][icedtea-web] Removing applications tab in jawas-about

[Andrew Azores]

Changelog:
* Makefile.am (stamps/netx-html-gen): removed logic for extras.jar, 
added new stamp to create HTML for AboutDialog
* netx/net/sourceforge/jnlp/about/AboutDialog.java: Moved out of extras 
into netx and renamed from Main. New Swing layout and uses HTML files 
generated in Makefile.
* netx/net/sourceforge/jnlp/about/HTMLPanel.java: Moved out of extras 
into netx. Added ability to click hyperlinks.
* netx/net/sourceforge/jnlp/runtime/Boot.java (main, getAboutFile, 
getJNLPFile, itwInfoMessage): changed way of launching About dialog to 
using new static display method rather than JNLP launch. Removed methods 
relating to JNLP launch. More informative and nicely formatted -headless 
information.

* netx/net/sourceforge/jnlp/resources/Messages.properties (BAboutITW, 
BFileInfoAuthors, BFileInfoCopying, BFileInfoNews): added new messages 
for javaws -about -headless launch
* netx/net/sourceforge/jnlp/resources/about.html: moved out of extras 
into netx. Added more content, changed formatting.
* netx/net/sourceforge/jnlp/resources/about.jnlp: removed, no longer needed
* netx/net/sourceforge/jnlp/resources/itw_logo.png: new image for About 
dialog. Modified version of javaws_splash.png
* netx/net/sourceforge/jnlp/resources/jamIcon.jpg: moved out of extras 
into netx

* extra/net/sourceforge/javaws/about/HTMLPanel.java: moved into netx
* extra/net/sourceforge/javaws/about/Main.java: same
* extra/net/sourceforge/javaws/about/resources/about.html: same
* extra/net/sourceforge/javaws/about/resources/jamIcon.jpg: same
* extra/net/sourceforge/javaws/about/resources/applications.html: removed
* extra/net/sourceforge/javaws/about/resources/notes.html: removed

On 07/08/2013 11:11 AM, Jiri Vanek wrote:
> Looks excellent! Two minor nits - I would like to have icedtea-web 
> homepage url and removed license header (sorry) in headless about 
> and.. see  general comments  below

Okay, fixed.

> This looks like it is not here (or is not working). The  -  public 
> static void  centerWindowsToCurrentScreen(Window w) { from 
> net.sourceforge.jnlp.util.ScreenFinder should do the trick.

Thanks, using that call now.

> A bit?? You are quite powerful make/sed/bash  magican. Feature will 
> prove how bullet proof this code is ;)
> You have included some comments, and it is really *appreciated* . 
> Maybe even more comments will be nice (eg split the greate regex on 
> start of target [to several lines with individual comments?]?)

:) thank you. Added more comments. Hopefully anyone who needs to 
maintain this in the future knows sed and regexes...

> Still several general comments:
>   - drop license header in headless mode. It does not looks nice. Sorry:(
>      - the  mentioning of COPYING file is more then enough
>   - add icedtea-web homepage url in headless about.
>   - you have duplicated the splash image. Tats wrong :) But as you did 
> it, I would recomand to shrink it  (so the source iamge have the same 
> size as result image), fill Iced (by some iced-blue) and make web more 
> dark - visible)
>    - my $0.002 +1 for having it a bit bigger then now O:)
>   - please update changelog for next round

I think all of this is handled now.

>
>  - several tests is depending on about.jar or other affected stuff You 
> will have to fix those:(
>    - see:  grep about -ir tests/
> tests/netx/unit/net/sourceforge/jnlp/runtime/CodeBaseClassLoaderTest.java: 
> testResourceCaching("net/sourceforge/jnlp/about/Main.class");
> tests/netx/unit/net/sourceforge/jnlp/runtime/CodeBaseClassLoaderTest.java: 
> testResourceCaching("net/sourceforge/jnlp/about/Main.class");
> tests/netx/unit/net/sourceforge/jnlp/runtime/CodeBaseClassLoaderTest.java: 
> testResourceCaching("net/sourceforge/jnlp/about/resources/about.html");
> tests/netx/unit/net/sourceforge/jnlp/runtime/CodeBaseClassLoaderTest.java: 
> testResourceCaching("net/sourceforge/jnlp/about/resources/about.html");
> tests/netx/unit/net/sourceforge/jnlp/runtime/CodeBaseClassLoaderTest.java: 
> testResourceCaching("net/sourceforge/jnlp/about/Main_FOO_.class", false);
> tests/netx/unit/net/sourceforge/jnlp/runtime/CodeBaseClassLoaderTest.java: 
> testResourceCaching("net/sourceforge/jnlp/about/Main_FOO_.class", false);
>
> ^^ Here and here ˇˇ you will have to create soem jar via jar and javac 
> api.
>
> tests/test-extensions/net/sourceforge/jnlp/mock/DummyJNLPFile.java: 
> JAR_URL = new URL("http://icedtea.classpath.org/netx/about.jar");
> tests/test-extensions/net/sourceforge/jnlp/ContentReader.java: 
> //mostly compaling when assassin kill the process about StreamClosed
>
> tests/reproducers/simple/LocalesTest/testcases/LocalesTestTest.java: 
> "BOAbout",
>
> Thsi one expects the BOAbout to be printed, but it looks like you have 
> dropped this "ssentence"

We talked about this on IRC but these tests actually are not affected by 
these changes because they download an old version of about.jar from the 
Internet anyway.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix.patch
Type: text/x-patch
Size: 14733 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130709/cd86e282/fix.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: last.patch
Type: text/x-patch
Size: 14558 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130709/cd86e282/last.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Makefile.am.patch
Type: text/x-patch
Size: 8928 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130709/cd86e282/Makefile.am.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: resources.patch
Type: text/x-patch
Size: 9607 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20130709/cd86e282/resources.patch