[rfc][icedtea-web] jnlp_href extensions inside HTML applets - PR974

[Andrew Azores]

Ping - any takers to review this one? :)

Andrew A

----- Original Message -----
From: "Andrew Azores" <aazores at redhat.com>
To: distro-pkg-dev at openjdk.java.net
Sent: Tuesday, June 25, 2013 3:47:13 PM
Subject: [rfc][icedtea-web] jnlp_href extensions inside HTML applets - PR974

Changelog:

* netx/net/sourceforge/jnlp/PluginBridge.java (PluginBridge, 
getResources): Constructor stores list of JNLP extensions, getResources 
returns this list

* 
tests/reproducers/custom/ExtensionJnlpsInApplet/testcases/ExtensionJnlpsInAppletTest.java: 
tests browser launch of HTML file with embedded JNLP applet referencing 
extension JNLP
* 
tests/reproducers/custom/ExtensionJnlpsInApplet/resources/ExtensionJnlpTest.html: 
same
* 
tests/reproducers/custom/ExtensionJnlpsInApplet/resources/ExtensionJnlpHelper.jnlp: 
same
* 
tests/reproducers/custom/ExtensionJnlpsInApplet/resources/ExtensionJnlpTestApplet.jnlp: 
same
* 
tests/reproducers/custom/ExtensionJnlpsInApplet/srcs/ExtensionJnlpHelper.java: 
same
* 
tests/reproducers/custom/ExtensionJnlpsInApplet/srcs/ExtensionJnlpTestApplet.java: 
same
* tests/reproducers/custom/ExtensionJnlpsInApplet/srcs/Makefile: same

PluginBridge had null parserSettings, which caused a NPE in JNLPFile 
parse() method later on. I wasn't sure if there was a particular reason 
why the PluginBridge constructor never called super(), so instead it 
instantiates a new ParserSettings on its own, with default values. The 
constructor also stores a list of extension JNLP files, which are then 
returned later when getResources is called with the param 
ExtensionDesc.class. The reproducer tests set up a scenario as described 
in the original bug report; one HTML file which uses jnlp_href tag. This 
JNLP file has another JNLP file as an extension. Each of these JNLP 
files references one JAR. One of these JARs contains a helper class 
which is referenced by a class in the other JAR. Previously this 
scenario would result in a NoClassDefFoundError for the helper class 
when a browser was used to load the HTML, although using javaws to 
launch the JNLP directly worked fine.

Thanks,

Andrew A