[rfc][icedtea-web] Removing applications tab in jawas-about

[Omair Majid]

Hi,

On 07/10/2013 03:27 PM, Andrew Azores wrote:
> On 07/10/2013 12:58 PM, Omair Majid wrote:
>> At some point, it might be a good idea to make this a stand-alone
>> script and invoke it from make. Keeping all this included in the
>> Makefile (with all the line-continuations) looks rather painful. 
> 
> Excellent idea.

I am going to assume there were no errors or typos in moving the code ;)

One style nit: we spaces for indentation, as much as possible.

> diff --git a/html-gen.sh b/html-gen.sh
> new file mode 100755
> --- /dev/null
> +++ b/html-gen.sh
> @@ -0,0 +1,91 @@
> +#!/bin/sh

I see a bunch of bash-isms in this script (including "[["), so you
probably want /bin/bash here. bash invoked as /bin/sh is normally more
lenient than other closer-to-sh shells (like dash).

May I suggest adding a one or two line comment to say what this script
does and how to run it?

> +	sed -i -r \
> +	-e "s/\t/    /g" ${c: Convert tabs into four spaces}\
> +	-e "s/\&/\&/g" ${c: "&" -> "&"}\
> +	-e "s/  /\ \ /g" ${c: Double-spaces into HTML whitespace for formatting}\
> +	-e "s/</\&lt;/g" ${c: "<" -> "&lt;"}\
> +	-e "s/>/\&gt;/g" ${c: ">" -> "&gt;"}\
> +	-e 's_(\&lt;)?(https?://[^ ]*)(\&gt;| |$$)_\1<a href="\2">\2</a>\3_i' ${c: Creates hyperlinks from http/https URLs}\
> +	-e 's/\&lt;(.*@.*)\&gt;/\&lt;<a href="mailto:\1\?subject=IcedTea-Web">\1<\/a>\&gt;/i' ${c: Create mailto links from email addresses formatted as <email at example.com>}\
> +	-e "s/$/<br>/g" ${c: "\n" -> "<br>"}\
> +	"./$FILE"

I would have just used multiple sed invocations + bash comments here,
instead of the (rather clever) parameter expansion. But it's your call.

Cheers,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681